From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Shin Subject: Re: od_set_powersave_bias: NULL pointer dereference Date: Thu, 27 Jun 2013 11:22:03 -0500 Message-ID: <20130627162203.GB5324@jshin-Toonie> References: <20130625161935.GA10208@jshin-Toonie> <20130626142852.GA2326@jshin-Toonie> <20130626175722.GA20226@jshin-Toonie> <20130627145505.GA3076@jshin-Toonie> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: cpufreq-owner@vger.kernel.org To: Viresh Kumar Cc: Tim Gardner , "Rafael J. Wysocki" , LKML , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Thu, Jun 27, 2013 at 08:50:44PM +0530, Viresh Kumar wrote: > BTW, your v1 is already applied and sent to Linus. So, > you need to send only fixup now. Here is the fixup delta patch, thanks! : ---8<--- >>From 133f670aa1dc450fd37ba39081d046bf238c507b Mon Sep 17 00:00:00 2001 From: Jacob Shin Date: Thu, 27 Jun 2013 10:44:42 -0500 Subject: [PATCH 1/1] cpufreq: don't leave stale policy pointer in cdbs->cur_policy Set ->cur_policy to NULL when stopping a governor. Otherwise, the ->cur_policy pointer may be stale on systems that have_governor_per_policy when a new policy is allocated due to CPU hotplug offline/online. Suggested-by: Viresh Kumar Signed-off-by: Jacob Shin --- drivers/cpufreq/cpufreq_governor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index dc9b72e..320474e 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -404,6 +404,7 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy, mutex_lock(&dbs_data->mutex); mutex_destroy(&cpu_cdbs->timer_mutex); + cpu_cdbs->cur_policy = NULL; mutex_unlock(&dbs_data->mutex); -- 1.7.10.4