Re: [PATCH v7 1/7] cpufreq: Add boost frequency support in core

Lukasz Majewski
2013-08-26T07:11:14Z

On Mon, 26 Aug 2013 12:36:47 +0530 Viresh Kumar viresh.kumar@linaro.org
wrote,
> On 26 August 2013 12:32, Lukasz Majewski <l.majewski@samsung.com>
> wrote:
> > On Mon, 26 Aug 2013 10:58:53 +0530 Viresh Kumar
> > viresh.kumar@linaro.org wrote,
> >> Some minor nitpicking, nothing much :)
> >
> > Is there any chance to pull those corrected patches to v3.12?
>
> Only Rafael can decide :)

:-)

>
> > After your comments I think, that this code could be rewritten:
> >
> >
> > list_for_each_entry(policy, &cpufreq_policy_list,
> > policy_list) { freq_table =
> > cpufreq_frequency_get_table(policy->cpu); if (freq_table) {
> > ret =
> > cpufreq_frequency_table_cpuinfo(policy, freq_table);
> > if (ret) {
> > pr_err("%s: Policy frequency update
> > failed\n")
>
> Don't break strings into multiple lines even if they cross 80
> columns.. And you missed __func__ :)

C code which turned into the pseudo code :-).

>
> > break;
> > }
> >
> > policy->user_policy.max = policy->max;
> > __cpufreq_governor(policy,CPUFREQ_GOV_LIMITS);
> > }
> > }
> >
> > return ret;
> > }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group