From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [RFC PATCH 3/3] cpuidle: big.LITTLE: vexpress-TC2 CPU idle driver Date: Fri, 26 Jul 2013 16:56:45 +0100 Message-ID: <20130726155645.GD28084@e102568-lin.cambridge.arm.com> References: <1374750866-750-1-git-send-email-lorenzo.pieralisi@arm.com> <1374750866-750-4-git-send-email-lorenzo.pieralisi@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:59866 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758011Ab3GZP4t convert rfc822-to-8bit (ORCPT ); Fri, 26 Jul 2013 11:56:49 -0400 In-Reply-To: Content-Disposition: inline Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Nicolas Pitre Cc: "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Kevin Hilman , Amit Kucheria , Olof Johansson , "Rafael J. Wysocki" , Daniel Lezcano , Jon Medhurst On Fri, Jul 26, 2013 at 04:00:48PM +0100, Nicolas Pitre wrote: > On Thu, 25 Jul 2013, Lorenzo Pieralisi wrote: > > > +static int notrace bl_powerdown_finisher(unsigned long arg) > > +{ > > + /* MCPM works with HW CPU identifiers */ > > + unsigned int mpidr = read_cpuid_mpidr(); > > + unsigned int cluster = (mpidr >> 8) & 0xf; > > + unsigned int cpu = mpidr & 0xf; > > You probably want to use the MPIDR_AFFINITY_LEVEL() macro here. Bah, I am so used to this pattern I don't notice anymore. Changed. Thanks ! Lorenzo