From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 012/228] cpufreq: sparc: call cpufreq_frequency_table_get_attr() Date: Fri, 13 Sep 2013 17:47:11 -0400 (EDT) Message-ID: <20130913.174711.268706749518726971.davem@davemloft.net> References: <56edbe14da9944ad026497bc1a0dc4aaa283d506.1379063063.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56edbe14da9944ad026497bc1a0dc4aaa283d506.1379063063.git.viresh.kumar@linaro.org> Sender: cpufreq-owner@vger.kernel.org To: viresh.kumar@linaro.org Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org List-Id: linux-pm@vger.kernel.org From: Viresh Kumar Date: Fri, 13 Sep 2013 18:29:18 +0530 > This exposes frequency table of driver to cpufreq core and is required for core > to guess what the index for a target frequency is, when it calls > cpufreq_frequency_table_target(). And so this driver needs to expose it. > > Cc: David S. Miller > Cc: sparclinux@vger.kernel.org > Signed-off-by: Viresh Kumar Wait a second, later in this series you add the put_attr() call claiming it's a fix. But you're the one adding the "bug" here. So if you are going to add a get_attr() call you should be adding the necessary put_attr() call in the same patch. Otherwise this patch introduces a bug.