From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Nilsson Subject: Re: [PATCH 187/228] cpufreq: cris: remove calls to cpufreq_notify_transition() Date: Fri, 13 Sep 2013 17:26:49 +0200 Message-ID: <20130913152649.GI32443@axis.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: cpufreq-owner@vger.kernel.org To: Viresh Kumar Cc: "rjw@sisk.pl" , "linaro-kernel@lists.linaro.org" , "patches@linaro.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jesper Nilsson , Mikael Starvik , linux-cris-kernel List-Id: linux-pm@vger.kernel.org On Fri, Sep 13, 2013 at 03:02:13PM +0200, Viresh Kumar wrote: > Most of the drivers do following in their ->target_index() routines: > > struct cpufreq_freqs freqs; > freqs.old = old freq... > freqs.new = new freq... > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); > > /* Change rate here */ > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); > > This is replicated over all cpufreq drivers today and there doesn't exists a > good enough reason why this shouldn't be moved to cpufreq core instead. > > Earlier patches have added support in cpufreq core to do cpufreq notification on > frequency change, this one removes it from this driver. > > Some related minor cleanups are also done along with it. Acked-by: Jesper Nilsson > Cc: Mikael Starvik > Cc: linux-cris-kernel@axis.com > Signed-off-by: Viresh Kumar /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com