From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v3 1/2] init/do_mounts.c: ignore final \n in name_to_dev_t Date: Thu, 3 Oct 2013 14:15:23 -0700 Message-ID: <20131003141523.8b60ab988799af7e2b2c338b@linux-foundation.org> References: <1380834638-24035-1-git-send-email-sebastian.capella@linaro.org> <1380834638-24035-2-git-send-email-sebastian.capella@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58151 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755234Ab3JCVPZ (ORCPT ); Thu, 3 Oct 2013 17:15:25 -0400 In-Reply-To: <1380834638-24035-2-git-send-email-sebastian.capella@linaro.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sebastian Capella Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, patches@linaro.org, "Eric W. Biederman" , Serge Hallyn , Stephen Warren , Jens Axboe , Greg Kroah-Hartman , Al Viro On Thu, 3 Oct 2013 14:10:37 -0700 Sebastian Capella wrote: > Enhance name_to_dev_t to handle trailing newline characters > on device paths. Some inputs to name_to_dev_t may come from > userspace where oftentimes a '\n' is appended to the path. > Added const to the name buffer in both the function > declaration and the prototype to reflect input buffer > handling. > > By handling trailing newlines in name_to_dev_t, userspace > buffers may be directly passed to name_to_dev_t without > modification. We have lib/string.c:strim() - perhaps this patch would be neater if it were to use it?