From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Nilsson Subject: Re: [PATCH V2 Resend 76/92] cpufreq: cris: use cpufreq_generic_init() routine Date: Thu, 3 Oct 2013 17:27:54 +0200 Message-ID: <20131003152754.GT11028@axis.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: cpufreq-owner@vger.kernel.org To: Viresh Kumar Cc: "rjw@sisk.pl" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Jesper Nilsson , Mikael Starvik , linux-cris-kernel List-Id: linux-pm@vger.kernel.org On Thu, Oct 03, 2013 at 04:59:10PM +0200, Viresh Kumar wrote: > Use generic cpufreq_generic_init() routine instead of replicating the same code > here. You should already have gotten my Acked-by: for this series, but here it is again: Acked-by: Jesper Nilsson > Cc: Mikael Starvik > Cc: linux-cris-kernel@axis.com > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/cris-artpec3-cpufreq.c | 6 +----- > drivers/cpufreq/cris-etraxfs-cpufreq.c | 5 +---- > 2 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/cpufreq/cris-artpec3-cpufreq.c b/drivers/cpufreq/cris-artpec3-cpufreq.c > index 4d88e4f..05fdc7e 100644 > --- a/drivers/cpufreq/cris-artpec3-cpufreq.c > +++ b/drivers/cpufreq/cris-artpec3-cpufreq.c > @@ -71,13 +71,9 @@ static int cris_freq_target(struct cpufreq_policy *policy, > > static int cris_freq_cpu_init(struct cpufreq_policy *policy) > { > - /* cpuinfo and default policy values */ > - policy->cpuinfo.transition_latency = 1000000; /* 1ms */ > - > - return cpufreq_table_validate_and_show(policy, cris_freq_table); > + return cpufreq_generic_init(policy, cris_freq_table, 1000000); > } > > - > static struct cpufreq_driver cris_freq_driver = { > .get = cris_freq_get_cpu_frequency, > .verify = cpufreq_generic_frequency_table_verify, > diff --git a/drivers/cpufreq/cris-etraxfs-cpufreq.c b/drivers/cpufreq/cris-etraxfs-cpufreq.c > index f7d2d49..fac2b26 100644 > --- a/drivers/cpufreq/cris-etraxfs-cpufreq.c > +++ b/drivers/cpufreq/cris-etraxfs-cpufreq.c > @@ -70,10 +70,7 @@ static int cris_freq_target(struct cpufreq_policy *policy, > > static int cris_freq_cpu_init(struct cpufreq_policy *policy) > { > - /* cpuinfo and default policy values */ > - policy->cpuinfo.transition_latency = 1000000; /* 1ms */ > - > - return cpufreq_table_validate_and_show(policy, cris_freq_table); > + return cpufreq_generic_init(policy, cris_freq_table, 1000000); > } > > static struct cpufreq_driver cris_freq_driver = { > -- > 1.7.12.rc2.18.g61b472e /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com