From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "corentin.chary@gmail.com" <corentin.chary@gmail.com>,
"acpi4asus-user@lists.sourceforge.net"
<acpi4asus-user@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2] platform: x86: asus-wmi: add fan control
Date: Sun, 13 Oct 2013 16:17:29 +0100 [thread overview]
Message-ID: <20131013151729.GA4028@srcf.ucam.org> (raw)
In-Reply-To: <CAMP44s04+_aP7KpVMTUjdNcRWMg6PC6HBaNhF_uhAHm=fhmTcw@mail.gmail.com>
On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote:
> I don't see anything in acpi_ex_system_memory_space_handler() that
> takes into consideration virtual addresses.
The spec doesn't seem to constrain it to physical addresses (it just
refers to "Control Methods read and write data to locations in address
spaces (for example, System memory and System I/O)", so I'd lean towards
changing the behaviour of acpica rather than adding virt_to_phys().
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-10-13 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 12:48 [PATCH v2] platform: x86: asus-wmi: add fan control Felipe Contreras
2013-10-08 12:57 ` Felipe Contreras
[not found] ` <CAHR064ge8zew7uMeD+_LXR3ju5ARGG1y8utLOFzOLexny_DPLA@mail.gmail.com>
2013-10-10 16:06 ` Matthew Garrett
2013-10-13 9:29 ` Felipe Contreras
2013-10-13 15:17 ` Matthew Garrett [this message]
2013-10-14 2:31 ` Felipe Contreras
2013-10-14 15:52 ` Matthew Garrett
2013-10-14 23:18 ` Felipe Contreras
2013-10-14 23:22 ` Matthew Garrett
2013-10-14 23:27 ` Felipe Contreras
2013-10-14 23:34 ` Matthew Garrett
2013-10-15 0:22 ` Felipe Contreras
2013-10-13 8:49 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131013151729.GA4028@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).