From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v3 07/14] ARM: mvebu: Add a new set of registers for pmsu Date: Mon, 14 Oct 2013 16:34:49 +0200 Message-ID: <20131014163449.5944e087@skate> References: <1381759106-15004-1-git-send-email-gregory.clement@free-electrons.com> <1381759106-15004-8-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from top.free-electrons.com ([176.31.233.9]:33079 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750892Ab3JNOex (ORCPT ); Mon, 14 Oct 2013 10:34:53 -0400 In-Reply-To: <1381759106-15004-8-git-send-email-gregory.clement@free-electrons.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Gregory CLEMENT Cc: Daniel Lezcano , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, lorenzo.pieralisi@arm.com, Jason Cooper , Andrew Lunn , Ezequiel Garcia , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Nicolas Pitre , Lior Amsalem , Maen Suleiman , Tawfik Bayouk , Shadi Ammouri , Eran Ben-Avi , Yehuda Yitschak , Nadav Haklai , Ike Pan , Dan Frazier , Leif Lindholm , Jon Masters , David Marlin Dear Gregory CLEMENT, On Mon, 14 Oct 2013 15:58:19 +0200, Gregory CLEMENT wrote: > The Power Management Unit Service block also controls the Coherency > Fabric subsystem. This new set of registers is needed for the CPU idle > implementation for the Armada 370/XP, it allows to enter a deep CPU > idle state where the Coherency Fabric and the L2 cache are power down. power -> powered > This patch also adds warnings if one of the base registers set can't > be ioremapped. > > Signed-off-by: Gregory CLEMENT I believe the Device Tree binding documentation should be updated in this patch (which actually changes the driver offering the binding), rather than in PATCH 14/14 (which updates the particular DT of a given platform to use this new binding). Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com