From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "corentin.chary@gmail.com" <corentin.chary@gmail.com>,
"acpi4asus-user@lists.sourceforge.net"
<acpi4asus-user@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2] platform: x86: asus-wmi: add fan control
Date: Tue, 15 Oct 2013 00:22:39 +0100 [thread overview]
Message-ID: <20131014232239.GA29716@srcf.ucam.org> (raw)
In-Reply-To: <CAMP44s3O6z6-gVCqhCps7fKSKMbL9JSakZLfBUxqUYytrWFWKw@mail.gmail.com>
On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote:
> On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > It wouldn't be appropriate to alter the firmware behaviour by default,
> > but yeah, that's the kind of thing that the thermal framework exists to
> > do.
>
> Well, how do I do that? The driver is up and running, and I can
> manually set different fan speeds, however nothing seems to happen
> automatically when the temperature increases.
The easiest is to just do it from userspace. I think Intel have some
code for doing this, but I haven't looked at the thermal code for years.
> > I don't think you can easily register multiple drivers for the same WMI
> > device.
>
> I don't mean this one, I mean the standalone one. Actually, the first
> one I sent doesn't require all this system memory stuff.
Banging EC registers directly is the wrong thing to do. Going via WMI is
correct.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-10-14 23:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 12:48 [PATCH v2] platform: x86: asus-wmi: add fan control Felipe Contreras
2013-10-08 12:57 ` Felipe Contreras
[not found] ` <CAHR064ge8zew7uMeD+_LXR3ju5ARGG1y8utLOFzOLexny_DPLA@mail.gmail.com>
2013-10-10 16:06 ` Matthew Garrett
2013-10-13 9:29 ` Felipe Contreras
2013-10-13 15:17 ` Matthew Garrett
2013-10-14 2:31 ` Felipe Contreras
2013-10-14 15:52 ` Matthew Garrett
2013-10-14 23:18 ` Felipe Contreras
2013-10-14 23:22 ` Matthew Garrett [this message]
2013-10-14 23:27 ` Felipe Contreras
2013-10-14 23:34 ` Matthew Garrett
2013-10-15 0:22 ` Felipe Contreras
2013-10-13 8:49 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014232239.GA29716@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).