From: Borislav Petkov <bp@suse.de>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Eduardo Valentin <eduardo.valentin@ti.com>,
LKML <linux-kernel@vger.kernel.org>,
acme@redhat.com, dhowells@redhat.com, bp@suse.de,
gthelen@google.com, Rafael Wysocki <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v1] tools/thermal: Introduce tmon, a tool for thermal subsystem
Date: Tue, 15 Oct 2013 11:14:01 +0200 [thread overview]
Message-ID: <20131015091401.GA8013@pd.tnic> (raw)
In-Reply-To: <1381791747-7458-2-git-send-email-jacob.jun.pan@linux.intel.com>
On Mon, Oct 14, 2013 at 04:02:27PM -0700, Jacob Pan wrote:
> Increasingly, Linux is running on thermally constrained devices. The simple
> thermal relationship between processor and fan has become past for modern
> computers.
>
> As hardware vendors cope with the thermal constraints on their products,
> more sensors are added, new cooling capabilities are introduced. The
> complexity of the thermal relationship can grow exponentially among cooling
> devices, zones, sensors, and trip points. They can also change dynamically.
>
> To expose such relationship to the userspace, Linux generic thermal layer
> introduced sysfs entry at /sys/class/thermal with a matrix of symbolic
> links, trip point bindings, and device instances. To traverse such
> matrix by hand is not a trivial task. Testing is also difficult in that
> thermal conditions are often exception cases that hard to reach in
> normal operations.
>
> TMON is conceived as a tool to help visualize, tune, and test the
> complex thermal subsystem.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> tools/Makefile | 15 +-
> tools/thermal/tmon/Makefile | 47 ++++
> tools/thermal/tmon/README | 50 ++++
> tools/thermal/tmon/pid.c | 131 +++++++++
> tools/thermal/tmon/sysfs.c | 596 ++++++++++++++++++++++++++++++++++++++++
> tools/thermal/tmon/tmon.8 | 142 ++++++++++
> tools/thermal/tmon/tmon.c | 352 ++++++++++++++++++++++++
> tools/thermal/tmon/tmon.h | 204 ++++++++++++++
> tools/thermal/tmon/tui.c | 638 +++++++++++++++++++++++++++++++++++++++++++
> 9 files changed, 2173 insertions(+), 2 deletions(-)
> create mode 100644 tools/thermal/tmon/Makefile
> create mode 100644 tools/thermal/tmon/README
> create mode 100644 tools/thermal/tmon/pid.c
> create mode 100644 tools/thermal/tmon/sysfs.c
> create mode 100644 tools/thermal/tmon/tmon.8
> create mode 100644 tools/thermal/tmon/tmon.c
> create mode 100644 tools/thermal/tmon/tmon.h
> create mode 100644 tools/thermal/tmon/tui.c
Just a couple of notes/questions:
* Why does this have to be in the kernel src repo? I mean, it only
needs stable sysfs interface but other than that, it can very well be a
separate project on github or so. Or am I missing something?
* So I tried it and I can control the brightness and the target CPU
temperature, cool! :) The question is: can I cook my box with it or
there are protections like filtering values which might be detrimental
to the system? After all, I'm running it as root.
* Also, please run this through checkpatch first:
total: 1 errors, 0 warnings, 91 checks, 2202 lines checked
Also, the manpage should be checked for typos and excessive spaces.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-10-15 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 23:02 [PATCH v1] TMON thermal monitoring/tuning tool Jacob Pan
2013-10-14 23:02 ` [PATCH v1] tools/thermal: Introduce tmon, a tool for thermal subsystem Jacob Pan
2013-10-15 9:14 ` Borislav Petkov [this message]
2013-10-15 13:31 ` Jacob Pan
2013-10-15 13:41 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015091401.GA8013@pd.tnic \
--to=bp@suse.de \
--cc=acme@redhat.com \
--cc=dhowells@redhat.com \
--cc=eduardo.valentin@ti.com \
--cc=gthelen@google.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).