* [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c
@ 2013-12-18 17:46 Rashika Kheria
2013-12-18 18:40 ` josh
0 siblings, 1 reply; 3+ messages in thread
From: Rashika Kheria @ 2013-12-18 17:46 UTC (permalink / raw)
To: linux-kernel; +Cc: Zhang Rui, Eduardo Valentin, linux-pm, josh
Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c
because it is not used outside this file.
This eliminates the following warning in x86_pkg_temp_thermal.c:
drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/thermal/x86_pkg_temp_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/x86_pkg_temp_thermal.c b/drivers/thermal/x86_pkg_temp_thermal.c
index 7722cb9..972e1c7 100644
--- a/drivers/thermal/x86_pkg_temp_thermal.c
+++ b/drivers/thermal/x86_pkg_temp_thermal.c
@@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
return 0;
}
-int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
+static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
unsigned long temp)
{
u32 l, h;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c
2013-12-18 17:46 [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c Rashika Kheria
@ 2013-12-18 18:40 ` josh
2014-01-02 2:35 ` Zhang Rui
0 siblings, 1 reply; 3+ messages in thread
From: josh @ 2013-12-18 18:40 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, Zhang Rui, Eduardo Valentin, linux-pm
On Wed, Dec 18, 2013 at 11:16:02PM +0530, Rashika Kheria wrote:
> Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c
> because it is not used outside this file.
>
> This eliminates the following warning in x86_pkg_temp_thermal.c:
> drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/thermal/x86_pkg_temp_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/x86_pkg_temp_thermal.c b/drivers/thermal/x86_pkg_temp_thermal.c
> index 7722cb9..972e1c7 100644
> --- a/drivers/thermal/x86_pkg_temp_thermal.c
> +++ b/drivers/thermal/x86_pkg_temp_thermal.c
> @@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
> return 0;
> }
>
> -int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> +static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> unsigned long temp)
> {
> u32 l, h;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c
2013-12-18 18:40 ` josh
@ 2014-01-02 2:35 ` Zhang Rui
0 siblings, 0 replies; 3+ messages in thread
From: Zhang Rui @ 2014-01-02 2:35 UTC (permalink / raw)
To: josh; +Cc: Rashika Kheria, linux-kernel, Eduardo Valentin, linux-pm
On Wed, 2013-12-18 at 10:40 -0800, josh@joshtriplett.org wrote:
> On Wed, Dec 18, 2013 at 11:16:02PM +0530, Rashika Kheria wrote:
> > Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c
> > because it is not used outside this file.
> >
> > This eliminates the following warning in x86_pkg_temp_thermal.c:
> > drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
applied.
thanks,
rui
> > drivers/thermal/x86_pkg_temp_thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/x86_pkg_temp_thermal.c b/drivers/thermal/x86_pkg_temp_thermal.c
> > index 7722cb9..972e1c7 100644
> > --- a/drivers/thermal/x86_pkg_temp_thermal.c
> > +++ b/drivers/thermal/x86_pkg_temp_thermal.c
> > @@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
> > return 0;
> > }
> >
> > -int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> > +static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> > unsigned long temp)
> > {
> > u32 l, h;
> > --
> > 1.7.9.5
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-02 2:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-18 17:46 [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c Rashika Kheria
2013-12-18 18:40 ` josh
2014-01-02 2:35 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).