From: josh@joshtriplett.org
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <eduardo.valentin@ti.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c
Date: Wed, 18 Dec 2013 10:40:14 -0800 [thread overview]
Message-ID: <20131218184014.GD24229@cloud> (raw)
In-Reply-To: <20131218174602.GA27918@rashika>
On Wed, Dec 18, 2013 at 11:16:02PM +0530, Rashika Kheria wrote:
> Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c
> because it is not used outside this file.
>
> This eliminates the following warning in x86_pkg_temp_thermal.c:
> drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/thermal/x86_pkg_temp_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/x86_pkg_temp_thermal.c b/drivers/thermal/x86_pkg_temp_thermal.c
> index 7722cb9..972e1c7 100644
> --- a/drivers/thermal/x86_pkg_temp_thermal.c
> +++ b/drivers/thermal/x86_pkg_temp_thermal.c
> @@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
> return 0;
> }
>
> -int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> +static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> unsigned long temp)
> {
> u32 l, h;
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-18 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 17:46 [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c Rashika Kheria
2013-12-18 18:40 ` josh [this message]
2014-01-02 2:35 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218184014.GD24229@cloud \
--to=josh@joshtriplett.org \
--cc=eduardo.valentin@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).