From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad Date: Sat, 4 Jan 2014 19:48:13 +0200 Message-ID: <20140104174813.GL10961@minantech.com> References: <2513222.AheLcigoE8@vostro.rjw.lan> <52C7C7EE.1070407@redhat.com> <1676077.d8A9e8eo7M@vostro.rjw.lan> <52C84733.1090507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <52C84733.1090507@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Paolo Bonzini Cc: "Rafael J. Wysocki" , Dirk Brandewie , Kashyap Chamarthy , Josh Boyer , One Thousand Gnomes , Viresh Kumar , "cpufreq@vger.kernel.org" , Linux PM list , "Linux-Kernel@Vger. Kernel. Org" , "Richard W.M. Jones" List-Id: linux-pm@vger.kernel.org On Sat, Jan 04, 2014 at 06:38:59PM +0100, Paolo Bonzini wrote: > Il 04/01/2014 15:38, Rafael J. Wysocki ha scritto: > > Well, it's just a sanity check and it makes the problem go away for the reporter. > > > >> > Your patch is welcome but perhaps it should have a WARN_ON too. > > It has been pulled in already, so the WARN_ON() can only be added via a separate > > patch now. Would you like to prepare that patch? > > Yes, I'll add it together with the CPUID check. I'll send the patch so > that it can get into 3.14. > CPUID check, while correct, will sweep the problem under the rug. Current Linux logic should detect non working pstate in KVM. We should look into why this is not happening for nested. -- Gleb.