[PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE

[PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE

[Viresh Kumar]

arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence
must be dependent on CONFIG_BIG_LITTLE.

This was highlighted by Russell earlier when he reported this issue:

drivers/built-in.o: In function `bL_cpufreq_set_rate':
powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb'

Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 456ba5e..3275e9c 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -4,7 +4,7 @@
 
 config ARM_BIG_LITTLE_CPUFREQ
 	tristate "Generic ARM big LITTLE CPUfreq driver"
-	depends on ARM && ARM_CPU_TOPOLOGY && HAVE_CLK
+	depends on ARM && BIG_LITTLE && ARM_CPU_TOPOLOGY && HAVE_CLK
 	select PM_OPP
 	help
 	  This enables the Generic CPUfreq driver for ARM big.LITTLE platforms.
-- 
1.7.12.rc2.18.g61b472e

Re: [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE

[Russell King - ARM Linux]

On Mon, Jan 06, 2014 at 02:08:21AM +0100, Rafael J. Wysocki wrote:
> On Friday, January 03, 2014 03:51:39 PM Viresh Kumar wrote:
> > arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence
> > must be dependent on CONFIG_BIG_LITTLE.
> > 
> > This was highlighted by Russell earlier when he reported this issue:
> > 
> > drivers/built-in.o: In function `bL_cpufreq_set_rate':
> > powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb'
> > 
> > Reported-by: Russell King <linux@arm.linux.org.uk>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Queued up for 3.14, thanks!

This is actually a build fix, not a new feature, so IMHO it should go
in for 3.13.  Linus has said he's going to do -rc8 anyway next weekend
so -final is at the earliest two weeks away.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".

Re: [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE

[Rafael J. Wysocki]

On Friday, January 03, 2014 03:51:39 PM Viresh Kumar wrote:
> arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence
> must be dependent on CONFIG_BIG_LITTLE.
> 
> This was highlighted by Russell earlier when he reported this issue:
> 
> drivers/built-in.o: In function `bL_cpufreq_set_rate':
> powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb'
> 
> Reported-by: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Queued up for 3.14, thanks!

> ---
>  drivers/cpufreq/Kconfig.arm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 456ba5e..3275e9c 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -4,7 +4,7 @@
>  
>  config ARM_BIG_LITTLE_CPUFREQ
>  	tristate "Generic ARM big LITTLE CPUfreq driver"
> -	depends on ARM && ARM_CPU_TOPOLOGY && HAVE_CLK
> +	depends on ARM && BIG_LITTLE && ARM_CPU_TOPOLOGY && HAVE_CLK
>  	select PM_OPP
>  	help
>  	  This enables the Generic CPUfreq driver for ARM big.LITTLE platforms.
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE

[Russell King - ARM Linux]

On Mon, Jan 06, 2014 at 02:23:39AM +0100, Rafael J. Wysocki wrote:
> On Monday, January 06, 2014 12:58:56 AM Russell King - ARM Linux wrote:
> > On Mon, Jan 06, 2014 at 02:08:21AM +0100, Rafael J. Wysocki wrote:
> > > On Friday, January 03, 2014 03:51:39 PM Viresh Kumar wrote:
> > > > arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence
> > > > must be dependent on CONFIG_BIG_LITTLE.
> > > > 
> > > > This was highlighted by Russell earlier when he reported this issue:
> > > > 
> > > > drivers/built-in.o: In function `bL_cpufreq_set_rate':
> > > > powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb'
> > > > 
> > > > Reported-by: Russell King <linux@arm.linux.org.uk>
> > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > 
> > > Queued up for 3.14, thanks!
> > 
> > This is actually a build fix, not a new feature, so IMHO it should go
> > in for 3.13.  Linus has said he's going to do -rc8 anyway next weekend
> > so -final is at the earliest two weeks away.
> 
> Well, it can go into 3.13 too.
> 
> Thanks!

Thanks.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".

Re: [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE

[Rafael J. Wysocki]

On Monday, January 06, 2014 12:58:56 AM Russell King - ARM Linux wrote:
> On Mon, Jan 06, 2014 at 02:08:21AM +0100, Rafael J. Wysocki wrote:
> > On Friday, January 03, 2014 03:51:39 PM Viresh Kumar wrote:
> > > arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence
> > > must be dependent on CONFIG_BIG_LITTLE.
> > > 
> > > This was highlighted by Russell earlier when he reported this issue:
> > > 
> > > drivers/built-in.o: In function `bL_cpufreq_set_rate':
> > > powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb'
> > > 
> > > Reported-by: Russell King <linux@arm.linux.org.uk>
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > Queued up for 3.14, thanks!
> 
> This is actually a build fix, not a new feature, so IMHO it should go
> in for 3.13.  Linus has said he's going to do -rc8 anyway next weekend
> so -final is at the earliest two weeks away.

Well, it can go into 3.13 too.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE

[Rafael J. Wysocki]

On Monday, January 06, 2014 01:11:37 AM Russell King - ARM Linux wrote:
> On Mon, Jan 06, 2014 at 02:23:39AM +0100, Rafael J. Wysocki wrote:
> > On Monday, January 06, 2014 12:58:56 AM Russell King - ARM Linux wrote:
> > > On Mon, Jan 06, 2014 at 02:08:21AM +0100, Rafael J. Wysocki wrote:
> > > > On Friday, January 03, 2014 03:51:39 PM Viresh Kumar wrote:
> > > > > arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence
> > > > > must be dependent on CONFIG_BIG_LITTLE.
> > > > > 
> > > > > This was highlighted by Russell earlier when he reported this issue:
> > > > > 
> > > > > drivers/built-in.o: In function `bL_cpufreq_set_rate':
> > > > > powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb'
> > > > > 
> > > > > Reported-by: Russell King <linux@arm.linux.org.uk>
> > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > > 
> > > > Queued up for 3.14, thanks!
> > > 
> > > This is actually a build fix, not a new feature, so IMHO it should go
> > > in for 3.13.  Linus has said he's going to do -rc8 anyway next weekend
> > > so -final is at the earliest two weeks away.
> > 
> > Well, it can go into 3.13 too.
> > 
> > Thanks!
> 
> Thanks.

Well, actually, I was wrong.  It depends on stuff already queued up for 3.14,
so either I'd need to drag all that into 3.13, or it needs to wait for 3.14.

So it will wait, sorry about that.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.