From: Sebastian Capella <sebastian.capella@linaro.org>
To: Sebastian Capella <sebastian.capella@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Serge Hallyn <serge.hallyn@canonical.com>,
linaro-kernel@lists.linaro.org,
Stephen Warren <swarren@nvidia.com>,
linux-pm@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
patches@linaro.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v3 1/2] init/do_mounts.c: ignore final \n in name_to_dev_t
Date: Wed, 29 Jan 2014 10:29:56 -0800 [thread overview]
Message-ID: <20140129182956.14275.72264@capellas-linux> (raw)
In-Reply-To: <20140128205830.14275.80319@capellas-linux>
Hi Andrew,
By the way, I do see a call (sysfs_streq) in use for this purpose
other places. Sorry, I didn't find it while looking at the original
problem. I'm not sure if this is preferable, but it appears to have
been added specifically for the strings coming through sysfs.
My preference is copying the string and cleaning it up before passing
it to internal functions, even though we incur an allocation.
Thanks,
Sebastian
next prev parent reply other threads:[~2014-01-29 18:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 21:10 [PATCH v3 0/2] PM / Hibernate: sysfs resume Sebastian Capella
2013-10-03 21:10 ` [PATCH v3 1/2] init/do_mounts.c: ignore final \n in name_to_dev_t Sebastian Capella
2013-10-03 21:15 ` Andrew Morton
2013-10-03 21:42 ` Sebastian Capella
2013-10-03 23:47 ` Sebastian Capella
2013-10-10 17:50 ` Sebastian Capella
2013-10-10 22:47 ` Eric W. Biederman
2013-10-10 23:39 ` Sebastian Capella
2013-10-22 17:54 ` Sebastian Capella
2014-01-28 18:59 ` Sebastian Capella
2014-01-28 20:54 ` Andrew Morton
2014-01-28 20:58 ` Sebastian Capella
2014-01-29 18:29 ` Sebastian Capella [this message]
2014-01-29 18:41 ` Andrew Morton
2013-10-03 21:10 ` [PATCH v3 2/2] PM / Hibernate: use name_to_dev_t to parse resume Sebastian Capella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129182956.14275.72264@capellas-linux \
--to=sebastian.capella@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=serge.hallyn@canonical.com \
--cc=swarren@nvidia.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).