From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Capella Subject: Re: [PATCH v7 2/3] trivial: PM / Hibernate: clean up checkpatch in hibernate.c Date: Tue, 04 Feb 2014 15:22:22 -0800 Message-ID: <20140204232222.31169.83206@capellas-linux> References: <1391546631-7715-1-git-send-email-sebastian.capella@linaro.org> <1391546631-7715-3-git-send-email-sebastian.capella@linaro.org> <9487103.2jnJmCRm9n@vostro.rjw.lan> <20140204223733.30015.23993@capellas-linux> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20140204223733.30015.23993@capellas-linux> Sender: owner-linux-mm@kvack.org To: Sebastian Capella , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Pavel Machek , Len Brown List-Id: linux-pm@vger.kernel.org Quoting Sebastian Capella (2014-02-04 14:37:33) > Quoting Rafael J. Wysocki (2014-02-04 13:36:29) > > > static int __init resumedelay_setup(char *str) > > > { > > > - resume_delay =3D simple_strtoul(str, NULL, 0); > > > + int ret =3D kstrtoint(str, 0, &resume_delay); > > > + /* mask must_check warn; on failure, leaves resume_delay unchan= ged */ > > > + (void)ret; One unintended consequence of this change is that it'll now accept a negative integer parameter. I'll rework this to have the same behavior as before. BTW, one question, is the __must_check really needed on kstrtoint? Wouldn't it be acceptable to rely on kstrtoint to not update resume_delay if it's unable to parse an integer out of the string? Couldn't that be a sufficient effect without requiring checking the return? Thanks, Sebastian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org