From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v4 02/13] ARM: mvebu: remove the address parameter for ll_set_cpu_coherent Date: Wed, 19 Feb 2014 17:06:10 +0100 Message-ID: <20140219170610.779573a2@skate> References: <1392312816-17657-1-git-send-email-gregory.clement@free-electrons.com> <1392312816-17657-3-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from top.free-electrons.com ([176.31.233.9]:50397 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754273AbaBSQGe (ORCPT ); Wed, 19 Feb 2014 11:06:34 -0500 In-Reply-To: <1392312816-17657-3-git-send-email-gregory.clement@free-electrons.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Gregory CLEMENT Cc: Daniel Lezcano , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Lorenzo Pieralisi , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Lior Amsalem , Tawfik Bayouk , Nadav Haklai , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org Gregory, On Thu, 13 Feb 2014 18:33:25 +0100, Gregory CLEMENT wrote: > Until now the calling functions of ll_set_cpu_coherent() have to know > the base address of the coherency registers. This commit doesn't > expose anymore this address. This was needed to be able to use either > a virtual or a physical address. This patch add a check of the MMU bit > to choose the accurate address, then the calling function do have pass > this information. > > Signed-off-by: Gregory CLEMENT I think your commit log needs some review: I don't understand "This commit doesn't expose anymore this address." from your commit log. Do you mean that the address is no longer passed as argument to ll_set_cpu_coherent() ? Similarly, the sentence "This patch add a check of the MMU bit to choose the accurate address, then the calling function do have pass this information." seems incorrect, as the commit does quite the opposite: the calling function do *NOT* have to pass the base address of the coherency. Finally, your commit log doesn't explain *why* this change is necessary. At first sight, switching from using a function argument to a global variable looks like a step in the wrong direction. An explanation as to why this is the right direction seems needed here. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com