From: Sebastian Capella <sebastian.capella@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Russ Dill <Russ.Dill@ti.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Nicolas Pitre <nico@linaro.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Will Deacon <Will.Deacon@arm.com>,
Cyril Chemparathy <cyril@ti.com>,
Jonathan Austin <Jonathan.Austin@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk
Date: Sun, 23 Feb 2014 11:52:42 -0800 [thread overview]
Message-ID: <20140223195242.12998.36214@capellas-linux> (raw)
In-Reply-To: <20140222120910.GA9012@e102568-lin.cambridge.arm.com>
Quoting Lorenzo Pieralisi (2014-02-22 04:09:10)
> On Sat, Feb 22, 2014 at 10:38:40AM +0000, Russell King - ARM Linux wrote:
> > On Wed, Feb 19, 2014 at 04:12:54PM +0000, Lorenzo Pieralisi wrote:
> > > > + cpu_switch_mm(idmap_pgd, &init_mm);
> >
> > You need the idmap_pgd in place to call cpu_resume at it's physical
> > address. Other page tables just won't do here. It's well established
> > that this page table must be in place for the resume paths to work.
>
> Well, we do not need idmap page tables for copying the restore_pblist,
> but we do need a set of tables that won't be corrupted by the copy and
> idmap does the trick (I was confused because 1:1 mappings are not needed
> for the copy itself).
>
> The switch to idmap is done for us in soft_reboot anyway before jumping to
> cpu_resume and that's required, as you said.
Ok, so I'll leave the cpu_switch_mm as is for the next patchset.
Thanks Lorenzo, Russ and Russell!
Sebastian
next prev parent reply other threads:[~2014-02-23 19:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 1:52 [PATCH RFC v1 0/3] hibernation support on ARM Sebastian Capella
2014-02-19 1:52 ` [PATCH RFC v1 1/3] ARM: Add irq disabled version of soft_restart Sebastian Capella
2014-02-22 10:26 ` Russell King - ARM Linux
2014-02-24 23:13 ` Sebastian Capella
2014-02-25 0:22 ` Sebastian Capella
2014-02-25 7:56 ` Russ Dill
2014-02-25 10:27 ` Thomas Gleixner
2014-02-25 17:15 ` Russ Dill
2014-02-25 23:24 ` Sebastian Capella
2014-02-19 1:52 ` [PATCH RFC v1 2/3] Fix hibernation restore hang in freeze_processes Sebastian Capella
2014-02-24 7:09 ` Ming Lei
2014-02-19 1:52 ` [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk Sebastian Capella
2014-02-19 16:12 ` Lorenzo Pieralisi
2014-02-19 19:10 ` Russ Dill
2014-02-20 10:37 ` Lorenzo Pieralisi
2014-02-19 19:33 ` Sebastian Capella
2014-02-20 16:27 ` Lorenzo Pieralisi
2014-02-21 18:39 ` Sebastian Capella
2014-02-21 23:59 ` Sebastian Capella
2014-02-22 4:37 ` Sebastian Capella
2014-02-22 6:46 ` Russ Dill
2014-02-22 10:22 ` Russell King - ARM Linux
2014-02-22 10:16 ` Russell King - ARM Linux
2014-02-22 12:13 ` Lorenzo Pieralisi
2014-02-22 22:30 ` Pavel Machek
2014-02-21 1:01 ` Sebastian Capella
2014-02-22 10:38 ` Russell King - ARM Linux
2014-02-22 12:09 ` Lorenzo Pieralisi
2014-02-22 22:28 ` Pavel Machek
2014-02-23 19:52 ` Sebastian Capella [this message]
2014-02-23 20:02 ` Sebastian Capella
2014-02-25 11:32 ` Lorenzo Pieralisi
2014-02-25 17:55 ` Sebastian Capella
2014-02-26 10:24 ` Lorenzo Pieralisi
2014-02-26 17:50 ` Sebastian Capella
2014-02-26 19:03 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223195242.12998.36214@capellas-linux \
--to=sebastian.capella@linaro.org \
--cc=Catalin.Marinas@arm.com \
--cc=Jonathan.Austin@arm.com \
--cc=Russ.Dill@ti.com \
--cc=Will.Deacon@arm.com \
--cc=cyril@ti.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=nico@linaro.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).