Re: [RFC PATCH 3/6] PM / Voltagedomain: introduce voltage domain driver support

Mark Brown
2014-02-24T01:58:26Z

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Tue, Feb 18, 2014 at 02:32:20PM -0600, Nishanth Menon wrote:

> The current regulator model provides the basic building blocks for the
> transitions, however SoC drivers specific to each of these devices, be
> it cpufreq/devfreq have to replicate the logic for functionality.

> To simply the logic, we can hence introduce a layer that takes care
> of the mundane transition logic, registration mechanisms to provide
> the "user drivers" such as cpufreq/devfreq a generic interface, whose
> details are abstracted by the device tree description for the SoC on
> which the driver operates on.

This doesn't really provide a picture of what the generic interface
that's being offered is and...

> drivers/power/voltdm/Kconfig | 5 +
> drivers/power/voltdm/Makefile | 3 +
> drivers/power/voltdm/core.c | 347 +++++++++++++++++++++++--
> drivers/power/voltdm/voltage_domain_private.h | 86 ++++++
> 4 files changed, 424 insertions(+), 17 deletions(-)

...the diffstat doesn't make it obvious what the external interface is
either. It would be much easier to review this with a clearer picture
of what it's aiming to implement.

> + voltdm_np = of_parse_phandle(np, prop_name, 0);
> + if (voltdm_np) {
> + ret = of_parse_phandle_with_args(np, prop_name, "#voltdm-cells",
> + 0, args);
> + if (ret)
> + return ERR_PTR(ret);

There seems to be some DT stuff going on here, is the interface DT only?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]