linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: rosslagerwall@gmail.com
To: Vinson Lee <vlee@twopensource.com>
Cc: stable@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
	Len Brown <len.brown@intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Shatil Rafiullah <srafiullah@twopensource.com>
Subject: Re: [stable request <=3.7] acpi-cpufreq: set current frequency based on target P-State
Date: Wed, 26 Mar 2014 07:22:32 +0000	[thread overview]
Message-ID: <20140326072232.GA777@hobo.lan> (raw)
In-Reply-To: <CAHTgTXVEjNUMkrTNSyu+TtXc+Ac5PsD8Sp4m-7Md6UNwQfwkJQ@mail.gmail.com>

On Tue, Mar 25, 2014 at 03:53:40PM -0700, Vinson Lee wrote:
> On Tue, Mar 25, 2014 at 3:18 PM,  <rosslagerwall@gmail.com> wrote:
> > On Tue, Mar 25, 2014 at 03:04:16PM -0700, Vinson Lee wrote:
> >> Hi.
> >>
> >> Please backport upstream commit 8673b83bf2f013379453b4779047bf3c6ae387e4
> >> "acpi-cpufreq: set current frequency based on target P-State" to stable
> >> kernels 3.7 and earlier. This patch enables the kernel to control
> >> P-states on several platforms. Without this patch, the kernel was unable
> >> to control P-states on the same platforms.
> >>
> >> The upstream patch cleanly applies to 3.7.
> >>
> >> A backported patch is needed with the removal of SYSTEM_AMD_MSR_CAPABLE
> >> for kernels 3.6 and earlier.
> >>
> >
> > I seem to recall that the problem was a regression introduced by commit
> > 5a1c0228 (cpufreq: Avoid calling cpufreq driver's target() routine if
> > target_freq == policy->cur) which was introduced in the 3.8 cycle.  Are
> > you sure it is necessary for kernels < 3.8?
> >
> > Regards
> > --
> > Ross Lagerwall
> 
> 
> This specific patch allows P-states to work with the 3.4 kernel on
> several hardware platforms.
> 
> Perhaps this is not the correct patch to backport. However, P-states
> are not working properly with the 3.4 kernel, even though it does not
> have the regression commit 5a1c0228 "cpufreq: Avoid calling cpufreq
> driver's target() routine if target_freq == policy->cur" backported.
> 

Fair enough,

Cheers
-- 
Ross Lagerwall

  reply	other threads:[~2014-03-26  7:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20  2:14 [stable request <=3.5] acpi-cpufreq: set current frequency based on target P-State Vinson Lee
2013-12-20  8:19 ` Ross Lagerwall
2014-03-25 22:04   ` [stable request <=3.7] " Vinson Lee
2014-03-25 22:04     ` [PATCH] " Vinson Lee
2014-03-25 22:18     ` [stable request <=3.7] " rosslagerwall
2014-03-25 22:53       ` Vinson Lee
2014-03-26  7:22         ` rosslagerwall [this message]
2014-04-11 16:05       ` Greg KH
2014-03-31  8:50     ` Luís Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140326072232.GA777@hobo.lan \
    --to=rosslagerwall@gmail.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=srafiullah@twopensource.com \
    --cc=stable@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vlee@twopensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).