* [PATCH] cpufreq: at32ap: don't declare local variable as static
@ 2014-04-03 14:50 Viresh Kumar
2014-04-03 14:52 ` Hans-Christian Egtvedt
2014-04-08 12:12 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Viresh Kumar @ 2014-04-03 14:50 UTC (permalink / raw)
To: rjw
Cc: linaro-kernel, cpufreq, linux-pm, linux-kernel, egtvedt, lxoliva,
Viresh Kumar
Earlier commit:
commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656
Author: Viresh Kumar <viresh.kumar@linaro.org>
Date: Thu Jan 9 20:38:43 2014 +0530
cpufreq: introduce cpufreq_generic_get() routine
did some changes to driver and by mistake made cpuclk as a 'static' local
variable, which wasn't actually required. Fix it.
Reported-by: Alexandre Oliva <lxoliva@fsfla.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/at32ap-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
index a1c79f5..7b612c8 100644
--- a/drivers/cpufreq/at32ap-cpufreq.c
+++ b/drivers/cpufreq/at32ap-cpufreq.c
@@ -52,7 +52,7 @@ static int at32_set_target(struct cpufreq_policy *policy, unsigned int index)
static int at32_cpufreq_driver_init(struct cpufreq_policy *policy)
{
unsigned int frequency, rate, min_freq;
- static struct clk *cpuclk;
+ struct clk *cpuclk;
int retval, steps, i;
if (policy->cpu != 0)
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: at32ap: don't declare local variable as static
2014-04-03 14:50 [PATCH] cpufreq: at32ap: don't declare local variable as static Viresh Kumar
@ 2014-04-03 14:52 ` Hans-Christian Egtvedt
2014-04-08 12:12 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Hans-Christian Egtvedt @ 2014-04-03 14:52 UTC (permalink / raw)
To: Viresh Kumar; +Cc: rjw, linaro-kernel, cpufreq, linux-pm, linux-kernel, lxoliva
Around Thu 03 Apr 2014 20:20:36 +0530 or thereabout, Viresh Kumar wrote:
> Earlier commit:
> commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656
> Author: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Thu Jan 9 20:38:43 2014 +0530
>
> cpufreq: introduce cpufreq_generic_get() routine
>
> did some changes to driver and by mistake made cpuclk as a 'static' local
> variable, which wasn't actually required. Fix it.
>
> Reported-by: Alexandre Oliva <lxoliva@fsfla.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> drivers/cpufreq/at32ap-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
> index a1c79f5..7b612c8 100644
> --- a/drivers/cpufreq/at32ap-cpufreq.c
> +++ b/drivers/cpufreq/at32ap-cpufreq.c
> @@ -52,7 +52,7 @@ static int at32_set_target(struct cpufreq_policy *policy, unsigned int index)
> static int at32_cpufreq_driver_init(struct cpufreq_policy *policy)
> {
> unsigned int frequency, rate, min_freq;
> - static struct clk *cpuclk;
> + struct clk *cpuclk;
> int retval, steps, i;
>
> if (policy->cpu != 0)
--
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: at32ap: don't declare local variable as static
2014-04-03 14:50 [PATCH] cpufreq: at32ap: don't declare local variable as static Viresh Kumar
2014-04-03 14:52 ` Hans-Christian Egtvedt
@ 2014-04-08 12:12 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2014-04-08 12:12 UTC (permalink / raw)
To: Viresh Kumar
Cc: linaro-kernel, cpufreq, linux-pm, linux-kernel, egtvedt, lxoliva
On Thursday, April 03, 2014 08:20:36 PM Viresh Kumar wrote:
> Earlier commit:
> commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656
> Author: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Thu Jan 9 20:38:43 2014 +0530
>
> cpufreq: introduce cpufreq_generic_get() routine
>
> did some changes to driver and by mistake made cpuclk as a 'static' local
> variable, which wasn't actually required. Fix it.
>
> Reported-by: Alexandre Oliva <lxoliva@fsfla.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Queued up for the next pull request, thanks!
> ---
> drivers/cpufreq/at32ap-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
> index a1c79f5..7b612c8 100644
> --- a/drivers/cpufreq/at32ap-cpufreq.c
> +++ b/drivers/cpufreq/at32ap-cpufreq.c
> @@ -52,7 +52,7 @@ static int at32_set_target(struct cpufreq_policy *policy, unsigned int index)
> static int at32_cpufreq_driver_init(struct cpufreq_policy *policy)
> {
> unsigned int frequency, rate, min_freq;
> - static struct clk *cpuclk;
> + struct clk *cpuclk;
> int retval, steps, i;
>
> if (policy->cpu != 0)
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-08 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-03 14:50 [PATCH] cpufreq: at32ap: don't declare local variable as static Viresh Kumar
2014-04-03 14:52 ` Hans-Christian Egtvedt
2014-04-08 12:12 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).