From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Sebastian Capella <sebastian.capella@linaro.org>,
Pavel Machek <pavel@ucw.cz>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH RFC] PM / Hibernate: no kernel_power_off when pm_power_off NULL
Date: Wed, 16 Apr 2014 22:09:01 +0100 [thread overview]
Message-ID: <20140416210901.GK24070@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140416215718.7f58efd8@alan.etchedpixels.co.uk>
On Wed, Apr 16, 2014 at 09:57:18PM +0100, One Thousand Gnomes wrote:
> > I'd say scrap (a) _unless_ we're going to add while (1) loops to all
> > the architectures. Alternatively, we could just accept that
> > machine_power_off() may return and deal with that case (iow, not
> > crash) in generic code.
>
> What would the right behaviour be
>
> while(1);
>
> isn't really nice behaviour on a modern device
That's an entirely different question... one which also needs fixing
in the hibernate code. We already know that cpu_relax() in there is
a good thing to do, so that would be a good start.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-04-16 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 20:53 [PATCH RFC 0/1] PM / Hibernate: no kernel_power_off when pm_power_off Sebastian Capella
2014-03-20 20:53 ` [PATCH RFC] PM / Hibernate: no kernel_power_off when pm_power_off NULL Sebastian Capella
2014-03-20 21:23 ` Pavel Machek
2014-03-20 21:35 ` One Thousand Gnomes
2014-03-20 21:36 ` Sebastian Capella
2014-03-26 17:22 ` Sebastian Capella
2014-04-15 18:34 ` Sebastian Capella
2014-04-15 20:54 ` Russell King - ARM Linux
2014-04-15 21:18 ` Pavel Machek
2014-04-16 16:28 ` Sebastian Capella
2014-04-16 20:41 ` Russell King - ARM Linux
2014-04-16 20:57 ` One Thousand Gnomes
2014-04-16 21:09 ` Russell King - ARM Linux [this message]
2014-04-18 21:38 ` Sebastian Capella
2014-04-20 14:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416210901.GK24070@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sebastian.capella@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).