From: Eduardo Valentin <edubezval@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@rjwysocki.net, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
arvind.chauhan@arm.com, inderpal.s@samsung.com, nm@ti.com,
chander.kashyap@linaro.org, pavel@ucw.cz, len.brown@intel.com,
sudeep.holla@arm.com
Subject: Re: [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal
Date: Thu, 22 May 2014 10:52:09 -0400 [thread overview]
Message-ID: <20140522145209.GA5246@developer> (raw)
In-Reply-To: <c73c825beda0207867bd29e40fece217cbf15925.1400736536.git.viresh.kumar@linaro.org>
Hello Viresh,
On Thu, May 22, 2014 at 11:07:25AM +0530, Viresh Kumar wrote:
> cpufreq-cpu0 uses thermal framework to register a cooling device, but doesn't
> depend on it as there are dummy calls provided by thermal layer when
> CONFIG_THERMAL=n. So, we don't really need to mention thermal as a dependency
> for cpufreq-cpu0 in Kconfig.
I see your point.
>
> Remove it.
However, on CPUs that needs thermal managment, it makes sense to have
such dependency, from functional perspective. Mainly because scaling
frequency and voltage up would be allowed only when thermal management
is enabled.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 1fbe11f..4310997 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE
>
> config GENERIC_CPUFREQ_CPU0
> tristate "Generic CPU0 cpufreq driver"
> - depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
> + depends on HAVE_CLK && REGULATOR && OF
> select PM_OPP
> help
> This adds a generic cpufreq driver for CPU0 frequency management.
> --
> 2.0.0.rc2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-05-22 18:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 5:37 [PATCH V3 0/8] CPUFreq: Initialize CPU's OPP tables from CPU core Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal Viresh Kumar
2014-05-22 14:52 ` Eduardo Valentin [this message]
2014-05-23 4:33 ` Viresh Kumar
2014-05-23 13:21 ` Eduardo Valentin
2014-05-23 13:28 ` Viresh Kumar
2014-05-24 12:59 ` Pavel Machek
2014-05-26 4:04 ` Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 2/8] opp: of_init_opp_table(): return -ENOSYS when feature isn't implemented Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 3/8] opp: call of_node_{get|put}() from of_init_opp_table() Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 4/8] driver/core: cpu: initialize opp table Viresh Kumar
2014-05-26 23:32 ` Rafael J. Wysocki
2014-05-27 0:04 ` Viresh Kumar
2014-05-27 0:18 ` Viresh Kumar
2014-05-27 11:30 ` Rafael J. Wysocki
2014-05-22 5:37 ` [PATCH V3 5/8] cpufreq: arm_big_little: don't " Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 6/8] cpufreq: imx6q: " Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 7/8] cpufreq: cpufreq-cpu0: " Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 8/8] cpufreq: exynos5440: " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522145209.GA5246@developer \
--to=edubezval@gmail.com \
--cc=arvind.chauhan@arm.com \
--cc=chander.kashyap@linaro.org \
--cc=inderpal.s@samsung.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).