From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()' Date: Tue, 27 May 2014 19:05:31 -0700 Message-ID: <20140528020531.7816.5349@quantum> References: <20140521073457.GD31687@pengutronix.de> <00f65d1c-a375-40e7-b30a-cd8cb3ca87fc@BN1BFFO11FD020.protection.gbl> <9956925.Qsz2bH3rDg@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <9956925.Qsz2bH3rDg@vostro.rjw.lan> Sender: cpufreq-owner@vger.kernel.org To: "Rafael J. Wysocki" , Viresh Kumar Cc: =?utf-8?q?S=C3=B6ren_Brinkmann?= , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Russell King , Stephen Boyd , "linux-pm@vger.kernel.org" , Michal Simek , "cpufreq@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" List-Id: linux-pm@vger.kernel.org Quoting Rafael J. Wysocki (2014-05-26 04:22:32) > On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: > > On 23 May 2014 21:44, S=C3=B6ren Brinkmann wrote: > > > Viresh: Could you imagine something similar for cpufreq? You sugg= ested > > > migrating to Hz resolution. I guess that would ideally mean to fo= llow > > > the CCF to a 64-bit type for frequencies and increasing the resol= ution. > > > I have a messy patch migrating cpufreq and OPP to Hz and unsigned= long > > > that works on Zynq. But cpufreq has so many users that it would b= ecome > > > quite an undertaking. > > > And we'd need some new/amended OPP DT binding. > >=20 > > If we are going to migrate to Hz from KHz, I think we must consider= the > > 64 bit stuff right now, otherwise it will bite us later. > >=20 > > @Rafael: What do you think? >=20 > I agree as far as the 64-bit thing goes, but is switching to Hz reall= y > necessary? Rafael, Why should CPUfreq migrate to 64-bit if not switching to Hz? CPU clock rates are specified as KHz in CPUfreq via an unsigned int. On 32-bit systems that comes out to a max of 4.29THz (terahertz!)! Or maybe you meant, "I agree that the clock framework should switch to the 64-bit thing"? Personally I'd like to see the clock framework and cpufreq get on the same page (data type) for specifying clock rates, and the clock framework really should not use a granularity like KHz. In fact we have some fractional rates like 13.25Hz ... Thanks, Mike >=20 > Rafael >=20