From: Shawn Guo <shawn.guo@linaro.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Anson Huang <b20788@freescale.com>,
eduardo.valentin@ti.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH] Thermal: imx: correct critical trip temperature setting
Date: Mon, 30 Jun 2014 10:21:24 +0800 [thread overview]
Message-ID: <20140630022122.GA3338@shlinux2> (raw)
In-Reply-To: <1404095067.2289.6.camel@rzhang1-toshiba>
On Mon, Jun 30, 2014 at 10:24:27AM +0800, Zhang Rui wrote:
> On Fri, 2014-06-20 at 15:03 +0800, Anson Huang wrote:
> > On latest i.MX6 SOC with thermal calibration data of 0x5A100000,
> > the critical trip temperature will be an invalid value and
> > cause system auto shutdown as below log:
> >
> > thermal thermal_zone0: critical temperature reached(42 C),shutting down
> >
> > So, with universal formula for thermal sensor, only room
> > temperature point is calibrated, which means the calibration
> > data read from fuse only has valid data of bit [31:20], others
> > are all 0, the critical trip point temperature can NOT depend
> > on the hot point calibration data, here we set it to 20 C higher
> > than default passive temperature.
> >
> > Signed-off-by: Anson Huang <b20788@freescale.com>
>
> Shawn,
> what do you think of this patch?
I'm fine the with patch.
Acked-by: Shawn Guo <shawn.guo@linaro.org>
next prev parent reply other threads:[~2014-06-30 3:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:03 [PATCH] Thermal: imx: correct critical trip temperature setting Anson Huang
2014-06-30 2:24 ` Zhang Rui
2014-06-30 2:21 ` Shawn Guo [this message]
2014-07-01 1:22 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630022122.GA3338@shlinux2 \
--to=shawn.guo@linaro.org \
--cc=b20788@freescale.com \
--cc=eduardo.valentin@ti.com \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox