From: Joerg Roedel <joro@8bytes.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 1/6] PM / Hibernate: Create a Radix-Tree to store memory bitmap
Date: Sat, 19 Jul 2014 09:57:08 +0200 [thread overview]
Message-ID: <20140719075707.GI30979@8bytes.org> (raw)
In-Reply-To: <7231480.jWHmWTNGCG@vostro.rjw.lan>
On Sat, Jul 19, 2014 at 02:00:39AM +0200, Rafael J. Wysocki wrote:
> > +/*
> > + * alloc_rtree_node - Allocate a new node and add it to the radix
> > + * tree.
>
> Please make this a single line.
>
> > +static int add_rtree_block(struct mem_zone_bm_rtree *zone, gfp_t gfp_mask,
> > + int safe_needed, struct chain_allocator *ca)
> > +{
> > + struct rtree_node *node, *block, **dst;
> > + unsigned int levels_needed, block_nr;
> > + int i;
> > +
> > + block_nr = zone->blocks;
>
> This isn't proper kernel coding style. Please use spaces as separators
> before the "=" here and elsewhere.
Thanks for your comments, will fix this and resend next week.
Joerg
next prev parent reply other threads:[~2014-07-19 7:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 11:57 [PATCH 0/6] PM / Hibernate: Memory bitmap scalability improvements Joerg Roedel
2014-07-18 11:57 ` [PATCH 1/6] PM / Hibernate: Create a Radix-Tree to store memory bitmap Joerg Roedel
2014-07-19 0:00 ` Rafael J. Wysocki
2014-07-19 7:57 ` Joerg Roedel [this message]
2014-07-18 11:57 ` [PATCH 2/6] PM / Hibernate: Add memory_rtree_find_bit function Joerg Roedel
2014-07-18 11:57 ` [PATCH 3/6] PM / Hibernate: Implement position keeping in radix tree Joerg Roedel
2014-07-18 11:57 ` [PATCH 4/6] PM / Hibernate: Iterate over set bits instead of PFNs in swsusp_free() Joerg Roedel
2014-07-18 11:57 ` [PATCH 5/6] PM / Hibernate: Remove the old memory-bitmap implementation Joerg Roedel
2014-07-18 11:57 ` [PATCH 6/6] PM / Hibernate: Touch Soft Lockup Watchdog in rtree_next_node Joerg Roedel
2014-07-18 22:05 ` [PATCH 0/6] PM / Hibernate: Memory bitmap scalability improvements Rafael J. Wysocki
2014-07-19 7:55 ` Joerg Roedel
2014-07-19 10:26 ` Pavel Machek
2014-07-19 11:35 ` Joerg Roedel
2014-07-19 13:49 ` Pavel Machek
2014-07-21 8:32 ` Joerg Roedel
2014-07-21 11:45 ` Pavel Machek
2014-07-21 14:29 ` Joerg Roedel
2014-07-21 14:39 ` Pavel Machek
2014-07-21 15:55 ` Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2014-07-21 10:26 [PATCH 0/6 v2] " Joerg Roedel
2014-07-21 10:26 ` [PATCH 1/6] PM / Hibernate: Create a Radix-Tree to store memory bitmap Joerg Roedel
2014-07-21 22:36 ` Joerg Roedel
2014-07-21 23:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140719075707.GI30979@8bytes.org \
--to=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).