Re: [PATCH 1/3] irq / PM: New driver interface for wakeup interrupts

Alan Stern
2014-08-01T14:41:06Z

On Fri, 1 Aug 2014, Thomas Gleixner wrote:

> Anyone who thinks that this can and should be solved at the driver
> level is simply taking the wrong drugs or ran out of supply of the
> proper ones. Either call your shrink or your drug dealer to get out of
> that.

That's absolutely true, but there is a counterpoint: Some of the
problems in this area _must_ be fixed at the driver level.

In particular, any driver that:

doesn't prevent its device from generating interrupt requests
while the system is suspended

and allows its device to share an IRQ line with a wakeup source

has to be fixed. The situation is even worse if the driver's interrupt
handler blows up when called at an inopportune time (such as when
clocks or power supplies are off).

Unfortunately, the only reasonable way to find such drivers is to wait
and see when the bad combination of events happens.

Alan Stern