linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
	"eduardo.valentin@gmail.com" <eduardo.valentin@gmail.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"javi.merino@arm.com" <javi.merino@arm.com>
Subject: Re: [PATCH-REPOST] thermal: of: look for sensor driver parent node if device node missing
Date: Wed, 30 Jul 2014 09:20:17 -0400	[thread overview]
Message-ID: <20140730132017.GC14219@developer> (raw)
In-Reply-To: <53D7AE7E.8070104@nvidia.com>

Laxman,

On Tue, Jul 29, 2014 at 07:53:58PM +0530, Laxman Dewangan wrote:
> On Tuesday 29 July 2014 07:42 PM, Eduardo Valentin wrote:
> > Hello Laxman,
> >
> > On Fri, Jul 25, 2014 at 02:49:31PM +0530, Laxman Dewangan wrote:
> >> There are some mfd devices which supports junction thermal interrupt
> >> like ams,AS3722. The DT binding of these devices are defined as the
> >> flat and drivers for sub module of such devices are registered as
> >> the mfd_add_devices. In this method, the sub devices registered as
> >> platform driver and these do not have the of_node pointer on their
> >> device structure. In this case, use the parent of_node pointer to
> >> get the required of_node pointer.
> >>
> > Can you please elaborate a bit more on your proposal? So, you would
> > append the thermal zones on the DT node of the MFD device?
> 
> Yes, mfd node for ams,as3722 is flat node, almost all sub-module driver 
> have their property on this node only. Regulator have their own sub node 
> under this node.
> 
> as3722 {
>          compatible = "ams,as3722";
>          #gpio-contorller;
>          #gpio-cells = <2>;
>      ::::::::::
>          regulator {
>                  ::::
>          };
> };
> 
> 
> So in this, the thermal sensor driver's property is on the as3722 node 
> only and thermal zone need to refer this node for sensor.
> 
> However, as3722 thermal sensor driver is register as sub mfd devices 
> through mfd_add_devices() and thermal sensor drivers pdev->dev.of_node 
> does not have any valid pointer.

In such case, the MFD driver shall populate the required data while
creating the sub device, right?


      reply	other threads:[~2014-07-30 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25  9:19 [PATCH-REPOST] thermal: of: look for sensor driver parent node if device node missing Laxman Dewangan
2014-07-25  9:30 ` Javi Merino
2014-07-29 14:12 ` Eduardo Valentin
2014-07-29 14:23   ` Laxman Dewangan
2014-07-30 13:20     ` Eduardo Valentin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140730132017.GC14219@developer \
    --to=edubezval@gmail.com \
    --cc=eduardo.valentin@gmail.com \
    --cc=javi.merino@arm.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).