From: Pavel Machek <pavel@ucw.cz>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee,
Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH] Hibernate: check unsafe page should not in e820 reserved region
Date: Mon, 4 Aug 2014 15:08:11 +0200 [thread overview]
Message-ID: <20140804130810.GA23098@amd.pavel.ucw.cz> (raw)
In-Reply-To: <s5hlhr4v32f.wl%tiwai@suse.de>
> > +
> > + list_for_each_entry(region, &nosave_regions, list) {
> > + if (pfn >= region->start_pfn && pfn < region->end_pfn) {
> > + pr_err("PM: %#010llx in e820 nosave regsion: "
And while looking at it, this should probably be spelled "region".
...plus maybe past part of changelog here into the comment?
Otherwise looks good to me,
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-08-04 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 10:33 [PATCH] Hibernate: check unsafe page should not in e820 reserved region Lee, Chun-Yi
2014-08-04 12:42 ` Takashi Iwai
2014-08-04 13:08 ` Pavel Machek [this message]
2014-08-04 14:56 ` joeyli
2014-08-04 14:52 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804130810.GA23098@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).