From mboxrd@z Thu Jan 1 00:00:00 1970 From: joeyli Subject: Re: [PATCH] Hibernate: check unsafe page should not in e820 reserved region Date: Mon, 4 Aug 2014 22:56:40 +0800 Message-ID: <20140804145640.GE16024@linux-rxt1.site> References: <1407148396-21405-1-git-send-email-jlee@suse.com> <20140804130810.GA23098@amd.pavel.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.nue.novell.com ([195.135.221.5]:39793 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbaHDO4x (ORCPT ); Mon, 4 Aug 2014 10:56:53 -0400 Content-Disposition: inline In-Reply-To: <20140804130810.GA23098@amd.pavel.ucw.cz> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Pavel Machek Cc: Takashi Iwai , "Lee, Chun-Yi" , "Rafael J. Wysocki" , Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Hi Pavel, Thanks for your review! On Mon, Aug 04, 2014 at 03:08:11PM +0200, Pavel Machek wrote: > > > + > > > + list_for_each_entry(region, &nosave_regions, list) { > > > + if (pfn >= region->start_pfn && pfn < region->end_pfn) { > > > + pr_err("PM: %#010llx in e820 nosave regsion: " > > And while looking at it, this should probably be spelled "region". > > ...plus maybe past part of changelog here into the comment? > Oh, sorry for my typo! I will correct it and comment in next version. > Otherwise looks good to me, > > Acked-by: Pavel Machek > Pavel Regards Joey Lee