From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 1/3] cpufreq: cpu0: Release clk and regulator in remove function Date: Thu, 28 Aug 2014 13:30:03 +0800 Message-ID: <20140828053002.GB23836@dragon> References: <1409209212-18730-1-git-send-email-pramod.gurav@smartplayin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1409209212-18730-1-git-send-email-pramod.gurav@smartplayin.com> Sender: linux-arm-msm-owner@vger.kernel.org To: Pramod Gurav Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar List-Id: linux-pm@vger.kernel.org On Thu, Aug 28, 2014 at 12:00:10AM -0700, Pramod Gurav wrote: > This function releases clk and regulator in remove function for clean > unloading. > > CC: Shawn Guo > CC: "Rafael J. Wysocki" > CC: Viresh Kumar > Signed-off-by: Pramod Gurav > --- > drivers/cpufreq/cpufreq-cpu0.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index 0d2172b..e1574f8 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -229,6 +229,8 @@ static int cpu0_cpufreq_remove(struct platform_device *pdev) > cpufreq_cooling_unregister(cdev); > cpufreq_unregister_driver(&cpu0_cpufreq_driver); > dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table); > + clk_put(cpu_clk); > + regulator_put(cpu_reg); cpu_reg is optional for the driver, so it's more logical to check the availability before actually putting it? Shawn > > return 0; > } > -- > 1.7.0.4 >