linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Maciej Matraszek <m.matraszek@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s
Date: Wed, 10 Sep 2014 20:18:25 +0100	[thread overview]
Message-ID: <20140910191825.GA7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1410348536-15201-1-git-send-email-m.matraszek@samsung.com>

On Wed, Sep 10, 2014 at 01:28:56PM +0200, Maciej Matraszek wrote:

> +static int pm_genpd_summary_open(struct inode *inode, struct file *file)
> +{
> +	return single_open(file, pm_genpd_summary_show, inode->i_private);
							^^^^^^^^^^^^^^^^
							what for?

Where in pm_genpd_summary_show() are you using ->private?

  parent reply	other threads:[~2014-09-10 19:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10 11:28 [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s Maciej Matraszek
2014-09-10 14:43 ` Greg Kroah-Hartman
2014-09-10 15:38   ` Maciej Matraszek
2014-09-10 18:27     ` Greg Kroah-Hartman
2014-09-11 17:02       ` Maciej Matraszek
2014-09-10 19:18 ` Al Viro [this message]
2014-09-11 16:52   ` Maciej Matraszek
2014-09-11  8:51 ` Geert Uytterhoeven
2014-09-11 16:45   ` Maciej Matraszek
2014-09-11 17:27     ` Geert Uytterhoeven
2014-09-12 16:19       ` Maciej Matraszek
2014-09-17 11:09         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910191825.GA7996@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=b.zolnierkie@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=k.kozlowski@samsung.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=m.matraszek@samsung.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).