* [PATCH] new suspend_resume trace event for console resume
@ 2014-09-19 21:07 Todd E Brandt
2014-09-22 14:04 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Todd E Brandt @ 2014-09-19 21:07 UTC (permalink / raw)
To: linux-pm
This patch adds another suspend_resume trace event for analyze_suspend
to capture. The resume_console call can take several hundred milliseconds
if the printk buffer is full of debug info. The tool will now inform
testers of the wasted time and encourage them to disable it in
production builds.
Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
----
kernel/power/suspend.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index 18c6219..e837dd6 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -361,7 +361,9 @@ int suspend_devices_and_enter(suspend_state_t state)
suspend_test_start();
dpm_resume_end(PMSG_RESUME);
suspend_test_finish("resume devices");
+ trace_suspend_resume(TPS("resume_console"), state, true);
resume_console();
+ trace_suspend_resume(TPS("resume_console"), state, false);
Close:
platform_suspend_end(state);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] new suspend_resume trace event for console resume
2014-09-19 21:07 [PATCH] new suspend_resume trace event for console resume Todd E Brandt
@ 2014-09-22 14:04 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2014-09-22 14:04 UTC (permalink / raw)
To: todd.e.brandt; +Cc: linux-pm
On Friday, September 19, 2014 02:07:12 PM Todd E Brandt wrote:
> This patch adds another suspend_resume trace event for analyze_suspend
> to capture. The resume_console call can take several hundred milliseconds
> if the printk buffer is full of debug info. The tool will now inform
> testers of the wasted time and encourage them to disable it in
> production builds.
>
> Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
Queued up for 3.18, thanks!
> ----
> kernel/power/suspend.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
> index 18c6219..e837dd6 100644
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -361,7 +361,9 @@ int suspend_devices_and_enter(suspend_state_t state)
> suspend_test_start();
> dpm_resume_end(PMSG_RESUME);
> suspend_test_finish("resume devices");
> + trace_suspend_resume(TPS("resume_console"), state, true);
> resume_console();
> + trace_suspend_resume(TPS("resume_console"), state, false);
>
> Close:
> platform_suspend_end(state);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-22 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-19 21:07 [PATCH] new suspend_resume trace event for console resume Todd E Brandt
2014-09-22 14:04 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).