From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [PATCH 21/21] thermal: exynos: Make Exynos3250 TMU compatible with Exynos4412 Date: Fri, 10 Oct 2014 10:51:18 +0200 Message-ID: <20141010105118.2f05d40f@amdc2363> References: <1412872737-624-1-git-send-email-l.majewski@samsung.com> <1412872737-624-22-git-send-email-l.majewski@samsung.com> <54371B7E.5010600@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:27073 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbaJJIv7 (ORCPT ); Fri, 10 Oct 2014 04:51:59 -0400 In-reply-to: <54371B7E.5010600@samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Chanwoo Choi Cc: Eduardo Valentin , Zhang Rui , "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, Linux PM list , Kukjin Kim , Bartlomiej Zolnierkiewicz , Lukasz Majewski , Amit Daniel Kachhap , Kyungmin Park Hi Chanwoo, > On 10/10/2014 01:38 AM, Lukasz Majewski wrote: > > Since both SoCs have the same TMU IP block embedded on them, it is > > not necessary to maintain separate compatible entry. > > > > Signed-off-by: Lukasz Majewski > > --- > > drivers/thermal/samsung/exynos_tmu.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > > b/drivers/thermal/samsung/exynos_tmu.c index f1e8c9b..7818e2f 100644 > > --- a/drivers/thermal/samsung/exynos_tmu.c > > +++ b/drivers/thermal/samsung/exynos_tmu.c > > @@ -744,9 +744,6 @@ static irqreturn_t exynos_tmu_irq(int irq, void > > *id) > > static const struct of_device_id exynos_tmu_match[] = { > > { > > - .compatible = "samsung,exynos3250-tmu", > > - }, > > - { > > If you want to remove compatible string for Exynos3250, > you have to modify it on exynos3250.dtsi. > Thanks for pointing this out. I've overlooked this dtsi file. > Thanks, > Chanwoo Choi -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group