From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 0/7] power_supply: Decrement the device reference counter Date: Wed, 15 Oct 2014 14:18:41 +0200 Message-ID: <20141015121841.GA26579@amd> References: <1413290117-13082-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:44942 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbaJOMSo (ORCPT ); Wed, 15 Oct 2014 08:18:44 -0400 Content-Disposition: inline In-Reply-To: <1413290117-13082-1-git-send-email-k.kozlowski@samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Krzysztof Kozlowski Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Linus Walleij , Samuel Ortiz , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Konrad Rzeszutek Wilk , "Rafael J. Wysocki" , Lv Zheng , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Anton Vorontsov , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Hi! > The reference counter of device allocated for power supply was > incremented with each call to power_supply_get_by_name() and > power_supply_get_by_phandle(). > > Add a symmetric 'put' operation so the device could be released after > final put_device() call during supply unregistering. > > > Rebased on next-20141007 + mine [1] patchset. > Tested on Trats2 board (max77693 + charger manager). > > Kindly asking for reviewing/testing other drivers. I'm not sure if we should support power_supply_put(NULL), but otherwise the series looks ok to me. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html