* [PATCH 2/2] Thermal:Remove usless if(!result) before return tz
@ 2014-10-20 8:27 Yao Dongdong
2014-10-20 12:10 ` Eduardo Valentin
0 siblings, 1 reply; 4+ messages in thread
From: Yao Dongdong @ 2014-10-20 8:27 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin; +Cc: linux-pm, LKML, yaodongdong
result is always zero when comes here.
Signed-off-by:yaodongdong@huawei.com
---
drivers/thermal/thermal_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 5b7d466..19cac8e 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1568,8 +1568,7 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
thermal_zone_device_update(tz);
- if (!result)
- return tz;
+ return tz;
unregister:
release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
--
1.8.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] Thermal:Remove usless if(!result) before return tz
2014-10-20 8:27 [PATCH 2/2] Thermal:Remove usless if(!result) before return tz Yao Dongdong
@ 2014-10-20 12:10 ` Eduardo Valentin
2014-10-21 3:34 ` Yao Dongdong
0 siblings, 1 reply; 4+ messages in thread
From: Eduardo Valentin @ 2014-10-20 12:10 UTC (permalink / raw)
To: Yao Dongdong; +Cc: Zhang Rui, linux-pm, LKML
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
Hello Yao
On Mon, Oct 20, 2014 at 04:27:59PM +0800, Yao Dongdong wrote:
> result is always zero when comes here.
>
> Signed-off-by:yaodongdong@huawei.com
>
> ---
> drivers/thermal/thermal_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 5b7d466..19cac8e 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1568,8 +1568,7 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
>
> thermal_zone_device_update(tz);
>
> - if (!result)
> - return tz;
> + return tz;
>
Adding a return here will make the resource release below not reachable
in the fail path.
> unregister:
> release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
> --
> 1.8.0.1
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Thermal:Remove usless if(!result) before return tz
2014-10-20 12:10 ` Eduardo Valentin
@ 2014-10-21 3:34 ` Yao Dongdong
2014-10-21 11:49 ` Eduardo Valentin
0 siblings, 1 reply; 4+ messages in thread
From: Yao Dongdong @ 2014-10-21 3:34 UTC (permalink / raw)
To: Eduardo Valentin; +Cc: Zhang Rui, linux-pm, LKML
On 2014/10/20 20:10, Eduardo Valentin wrote:
> Hello Yao
>
> On Mon, Oct 20, 2014 at 04:27:59PM +0800, Yao Dongdong wrote:
>> result is always zero when comes here.
>>
>> Signed-off-by:yaodongdong@huawei.com
>>
>> ---
>> drivers/thermal/thermal_core.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
>> index 5b7d466..19cac8e 100644
>> --- a/drivers/thermal/thermal_core.c
>> +++ b/drivers/thermal/thermal_core.c
>> @@ -1568,8 +1568,7 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
>>
>> thermal_zone_device_update(tz);
>>
>> - if (!result)
>> - return tz;
>> + return tz;
>>
> Adding a return here will make the resource release below not reachable
> in the fail path.
But all fails above followed a "goto unregister", so i think it must be successful when come here.
Thanks.
>> unregister:
>> release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
>> --
>> 1.8.0.1
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Thermal:Remove usless if(!result) before return tz
2014-10-21 3:34 ` Yao Dongdong
@ 2014-10-21 11:49 ` Eduardo Valentin
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Valentin @ 2014-10-21 11:49 UTC (permalink / raw)
To: Yao Dongdong; +Cc: Zhang Rui, linux-pm, LKML
[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]
Hello Yao,
On Tue, Oct 21, 2014 at 11:34:37AM +0800, Yao Dongdong wrote:
>
> On 2014/10/20 20:10, Eduardo Valentin wrote:
> > Hello Yao
> >
> > On Mon, Oct 20, 2014 at 04:27:59PM +0800, Yao Dongdong wrote:
> >> result is always zero when comes here.
> >>
> >> Signed-off-by:yaodongdong@huawei.com
> >>
> >> ---
> >> drivers/thermal/thermal_core.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> >> index 5b7d466..19cac8e 100644
> >> --- a/drivers/thermal/thermal_core.c
> >> +++ b/drivers/thermal/thermal_core.c
> >> @@ -1568,8 +1568,7 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
> >>
> >> thermal_zone_device_update(tz);
> >>
> >> - if (!result)
> >> - return tz;
> >> + return tz;
> >>
> > Adding a return here will make the resource release below not reachable
> > in the fail path.
>
> But all fails above followed a "goto unregister", so i think it must be successful when come here.
Yes, I see your point. Agreed.
Acked-by: Eduardo Valentin <edubezval@gmail.com>
>
> Thanks.
>
> >> unregister:
> >> release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
> >> --
> >> 1.8.0.1
> >>
> >>
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-21 11:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-20 8:27 [PATCH 2/2] Thermal:Remove usless if(!result) before return tz Yao Dongdong
2014-10-20 12:10 ` Eduardo Valentin
2014-10-21 3:34 ` Yao Dongdong
2014-10-21 11:49 ` Eduardo Valentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).