From: Johan Hovold <johan@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Johan Hovold" <johan@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Alan Cox" <gnomes@lxorguk.ukuu.org.uk>,
"Alexander Graf" <agraf@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Len Brown" <len.brown@intel.com>, "Pavel Machek" <pavel@ucw.cz>,
"Philippe Rétornaz" <philippe.retornaz@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Romain Perier" <romain.perier@gmail.com>
Subject: Re: [PATCH v2 01/47] kernel: Add support for poweroff handler call chain
Date: Tue, 21 Oct 2014 20:27:50 +0200 [thread overview]
Message-ID: <20141021182750.GC2113@localhost> (raw)
In-Reply-To: <20141021155047.GA3453@roeck-us.net>
On Tue, Oct 21, 2014 at 08:50:47AM -0700, Guenter Roeck wrote:
> On Tue, Oct 21, 2014 at 11:34:05AM +0200, Johan Hovold wrote:
> > On Mon, Oct 20, 2014 at 09:12:17PM -0700, Guenter Roeck wrote:
> >
> > > v2:
> > > - poweroff -> power_off
> >
> > Do you want to stick to power[-_ ]off consistently throughout?
> >
>
> The string "poweroff" is used 819 times in today's upstream kernel.
> "power_off" is used 1,496 times, presumably mostly in variable names.
> "power-off" is used 145 times.
>
> So, yes, I can change all newly introduced variable and function names
> from poweroff to power_off, and all newly introduced descriptive text
> from poweroff to power-off if that makes you happy. It won't improve
> consistency, though, since many of the current poweroff functions
> are named "something_poweroff". Hope you don't expect me to change
> all those function names as well.
Consistency is always nice, even if it's just within the files and
infrastructure you're adding.
But as already mentioned, the most important thing is that the interface
is consistent (e.g. function and constant names).
Johan
next prev parent reply other threads:[~2014-10-21 18:30 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 4:12 [PATCH v2 00/47] kernel: Add support for poweroff handler call chain Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 01/47] " Guenter Roeck
2014-10-21 6:46 ` Philippe Rétornaz
2014-10-21 13:29 ` Guenter Roeck
2014-10-22 8:02 ` Philippe Rétornaz
2014-10-22 13:22 ` Guenter Roeck
2014-10-21 9:34 ` Johan Hovold
2014-10-21 10:30 ` Lee Jones
2014-10-21 13:32 ` Guenter Roeck
2014-10-21 13:34 ` Guenter Roeck
2014-10-21 15:50 ` Guenter Roeck
2014-10-21 18:27 ` Johan Hovold [this message]
2014-10-21 12:26 ` Rafael J. Wysocki
2014-10-21 12:44 ` Heiko Stübner
2014-10-21 13:17 ` Guenter Roeck
2014-10-21 14:15 ` Rafael J. Wysocki
2014-10-21 16:11 ` Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 02/47] memory: emif: Use API function to determine poweroff capability Guenter Roeck
2014-10-22 18:48 ` Santosh Shilimkar
2014-10-22 22:18 ` Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 03/47] hibernate: Call have_kernel_power_off instead of checking pm_power_off Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 04/47] m68k: Replace mach_power_off with pm_power_off Guenter Roeck
2014-10-22 3:50 ` Greg Ungerer
2014-10-21 4:12 ` [PATCH v2 05/47] mfd: as3722: Drop reference to pm_power_off from devicetree bindings Guenter Roeck
2014-10-21 8:15 ` Lee Jones
2014-10-21 4:12 ` [PATCH v2 06/47] gpio-poweroff: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 07/47] qnap-poweroff: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 08/47] kernel: Move pm_power_off to common code Guenter Roeck
2014-10-22 15:31 ` Ralf Baechle
2014-10-22 15:43 ` Guenter Roeck
2014-10-24 9:47 ` James Hogan
2014-10-24 15:53 ` Guenter Roeck
2014-10-24 10:02 ` [uml-user] " Lennox Wu
2014-10-24 10:03 ` Lennox Wu
2014-10-21 4:12 ` [PATCH v2 09/47] mfd: palmas: Register with kernel poweroff handler Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 10/47] mfd: axp20x: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 11/47] mfd: retu: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 12/47] mfd: ab8500-sysctrl: " Guenter Roeck
2014-10-27 15:59 ` Linus Walleij
2014-10-27 16:42 ` Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 13/47] mfd: max8907: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 14/47] mfd: tps80031: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 15/47] mfd: dm355evm_msp: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 16/47] mfd: tps6586x: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 17/47] mfd: tps65910: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 18/47] mfd: twl4030-power: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 19/47] mfd: rk808: Register poweroff handler " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 20/47] mfd: rn5t618: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 21/47] ipmi: Register " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 22/47] power/reset: restart-poweroff: " Guenter Roeck
2014-10-22 21:32 ` Sebastian Reichel
2014-10-22 22:19 ` Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 23/47] power/reset: gpio-poweroff: " Guenter Roeck
2014-10-22 21:32 ` Sebastian Reichel
2014-10-21 4:12 ` [PATCH v2 24/47] power/reset: as3722-poweroff: " Guenter Roeck
2014-10-22 21:33 ` Sebastian Reichel
2014-10-21 4:12 ` [PATCH v2 25/47] power/reset: qnap-poweroff: " Guenter Roeck
2014-10-22 21:33 ` Sebastian Reichel
2014-10-21 4:12 ` [PATCH v2 26/47] power/reset: msm-poweroff: " Guenter Roeck
2014-10-22 21:33 ` Sebastian Reichel
2014-10-21 4:12 ` [PATCH v2 27/47] power/reset: vexpress-poweroff: " Guenter Roeck
2014-10-22 21:34 ` Sebastian Reichel
2014-10-21 4:12 ` [PATCH v2 28/47] power/reset: at91-poweroff: " Guenter Roeck
2014-10-22 21:34 ` Sebastian Reichel
2014-10-21 4:12 ` [PATCH v2 29/47] power/reset: ltc2952-poweroff: " Guenter Roeck
2014-10-22 21:35 ` Sebastian Reichel
2014-10-21 4:12 ` [PATCH v2 30/47] x86: iris: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 31/47] x86: apm: " Guenter Roeck
2014-10-21 8:46 ` Jiri Kosina
2014-10-21 4:12 ` [PATCH v2 32/47] x86: olpc: Register xo1 poweroff handler " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 33/47] staging: nvec: Register " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 34/47] acpi: Register poweroff handler " Guenter Roeck
2014-10-21 12:27 ` Rafael J. Wysocki
2014-10-21 4:12 ` [PATCH v2 35/47] arm: Register " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 36/47] arm64: psci: " Guenter Roeck
2014-10-22 11:23 ` Catalin Marinas
2014-10-22 15:38 ` Guenter Roeck
2014-10-22 12:52 ` Mark Rutland
2014-10-22 15:37 ` Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 37/47] avr32: atngw100: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 38/47] ia64: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 39/47] m68k: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 40/47] mips: " Guenter Roeck
2014-10-22 15:32 ` Ralf Baechle
2014-10-22 15:44 ` Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 41/47] sh: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 42/47] x86: lguest: " Guenter Roeck
2014-10-21 4:12 ` [PATCH v2 43/47] x86: ce4100: " Guenter Roeck
2014-10-21 4:13 ` [PATCH v2 44/47] x86: intel-mid: Drop registration of dummy poweroff handlers Guenter Roeck
2014-10-21 4:13 ` [PATCH v2 45/47] x86: pmc_atom: Register poweroff handler with kernel poweroff handler Guenter Roeck
2014-10-21 4:13 ` [PATCH v2 46/47] efi: " Guenter Roeck
2014-10-21 4:13 ` [PATCH v2 47/47] kernel: Remove pm_power_off Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021182750.GC2113@localhost \
--to=johan@kernel.org \
--cc=agraf@suse.de \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pavel@ucw.cz \
--cc=philippe.retornaz@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).