From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org, lee.jones@linaro.org,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org,
Olliver Schinagl <oliver+list@schinagl.nl>
Subject: Re: [RFC Patch 1/4] mfd: AXP20x: Add power supply bindings documentation
Date: Tue, 21 Oct 2014 22:10:42 +0200 [thread overview]
Message-ID: <20141021201042.GB7893@lukather> (raw)
In-Reply-To: <20141020223314.0484f795@neptune.home>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On Mon, Oct 20, 2014 at 10:33:14PM +0200, Bruno Prémont wrote:
>
> ---
You're missing a commit log, and your signed-off-by.
You should go through Documentation/SubmittingPatches, and make sure
to run checkpatch.pl, and fix the warning and errors.
> Note: the OCV values seem to have some defaults build into the
> PMIC though may need adjustment if the used battery has a different
> open circuit voltage curve.
> As far as understood (these values are set in vendor driver but not
> mentioned in chip documentation) they represent charge percentage
> for some predefined voltages.
>
> If prefixing these values with "x-power," is preferred the following
> patch should becomes a dependency:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/267606.html
Feel free to fold that patch into your serie, since it seems to have
been forgotten.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-21 20:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141020215954.7f1d5502@neptune.home>
2014-10-20 20:19 ` [RFC Patch 0/4] mfd: AXP20x: Add power supply sub-driver Bruno Prémont
2014-10-20 20:33 ` [RFC Patch 2/4] " Bruno Prémont
[not found] ` <20141020223320.2b4ecba9-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2014-10-21 20:27 ` Maxime Ripard
2014-10-22 6:30 ` Bruno Prémont
[not found] ` <20141022083013.6b90be7e-I2t2yFIzmohO7ya8xxV06g@public.gmane.org>
2014-10-23 9:29 ` Maxime Ripard
[not found] ` <20141023201235.3b94cc82@smutje.local>
2014-11-03 20:14 ` Bruno Prémont
2014-10-20 20:33 ` [RFC Patch 4/4] mfd: AXP20x: Add backup battery DTS entry for Cubietruck Bruno Prémont
[not found] ` <20141020215954.7f1d5502-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
[not found] ` <20141020221959.2f312906-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2014-10-20 20:33 ` [RFC Patch 1/4] mfd: AXP20x: Add power supply bindings documentation Bruno Prémont
[not found] ` <20141020223314.0484f795-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2014-10-21 10:15 ` Lee Jones
2014-10-21 16:09 ` Bruno Prémont
[not found] ` <20141021180916.432f02e1-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2014-10-21 19:19 ` Maxime Ripard
2014-11-03 20:02 ` Bruno Prémont
[not found] ` <20141103210244.1425e0c7-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2014-11-04 14:09 ` Ezaul Zillmer
2014-11-04 21:21 ` Bruno Prémont
[not found] ` <20141104222124.1bc7e6ec-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2014-11-05 12:29 ` Ezaul Zillmer
2014-11-04 14:31 ` Maxime Ripard
2014-11-04 21:08 ` Bruno Prémont
[not found] ` <20141104220827.773c53d0-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2014-11-05 14:48 ` Maxime Ripard
2014-11-05 14:55 ` Koen Kooi
2014-10-21 20:10 ` Maxime Ripard [this message]
2014-10-20 20:33 ` [RFC Patch 3/4] mfd: AXP20x: Add power supply defconfig entries Bruno Prémont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021201042.GB7893@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=bonbons@linux-vserver.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=oliver+list@schinagl.nl \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox