Re: [PATCH v2 1/2] power_supply: Add no_thermal property to prevent recursive get_temp calls

Sebastian Reichel
2014-10-27T18:29:58Z

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Hi,

On Tue, Oct 07, 2014 at 05:47:36PM +0200, Krzysztof Kozlowski wrote:
> Add a 'no_thermal' property to the power supply class. If true then
> thermal zone won't be created for this power supply in
> power_supply_register().
>
> Power supply drivers may want to set it if they support
> POWER_SUPPLY_PROP_TEMP and they are forwarding this get property call to
> other thermal zone.
>
> If they won't set it lockdep may report false positive deadlock for
> thermal zone's mutex because of nested calls to thermal_zone_get_temp().
> First is the call to thermal_zone_get_temp() of the driver's thermal
> zone. Thermal core gets POWER_SUPPLY_PROP_TEMP property from this
> driver. The driver then calls other thermal zone thermal_zone_get_temp()
> and returns result.
>
> Example of such driver is charger manager.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

pulled into next, I will include it in 3.18-rc pull request.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]