[PATCH v2] thermal: imx: correct driver load sequence for cpu cooling

[PATCH v2] thermal: imx: correct driver load sequence for cpu cooling

[Bai Ping]

From: Bai Ping <b51503@freescale.com>

thermal driver should be regisetered after cpufreq driver has
been registered and probed. Doing so is to make sure that thermal
driver can get the max cpu cooling states correctly when calling
get_property.

Signed-off-by: Bai Ping <b51503@freescale.com>
---
Changes for v2
-Address the comments from Eduardo Valentin

 drivers/thermal/imx_thermal.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 2c516f2..8697caf 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -406,6 +406,10 @@ static int imx_thermal_probe(struct platform_device *pdev)
 	int measure_freq;
 	int ret;
 
+	if (!cpufreq_get_current_driver()) {
+		dev_dbg(&pdev->dev, "no cpufreq driver!");
+		return -EPROBE_DEFER;
+	}
 	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
 	if (!data)
 		return -ENOMEM;
-- 
1.9.1

Re: [PATCH v2] thermal: imx: correct driver load sequence for cpu cooling

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

Hello Bai,

On Tue, Oct 14, 2014 at 01:12:07PM +0800, Bai Ping wrote:
> From: Bai Ping <b51503@freescale.com>
> 
> thermal driver should be regisetered after cpufreq driver has
> been registered and probed. Doing so is to make sure that thermal
> driver can get the max cpu cooling states correctly when calling
> get_property.
> 
> Signed-off-by: Bai Ping <b51503@freescale.com>
> ---
> Changes for v2
> -Address the comments from Eduardo Valentin
> 

Thanks for addressing the comments. Applied in my -fixes queue.

>  drivers/thermal/imx_thermal.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index 2c516f2..8697caf 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -406,6 +406,10 @@ static int imx_thermal_probe(struct platform_device *pdev)
>  	int measure_freq;
>  	int ret;
>  
> +	if (!cpufreq_get_current_driver()) {
> +		dev_dbg(&pdev->dev, "no cpufreq driver!");
> +		return -EPROBE_DEFER;
> +	}
>  	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
>  	if (!data)
>  		return -ENOMEM;
> -- 
> 1.9.1
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]