Re: [PATCH] thermal: core: ignore invalid trip temperature

[Lukasz Majewski <l.majewski@samsung.com>]

Hi Srinivas,

> Ignore invalid trip temperature less or equal to zero. Some
> buggy systems have invalid trips, causing system shutdown.
> 
> Signed-off-by: Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> Acked-by: Zhang Rui
> <rui.zhang@intel.com> ---
>  drivers/thermal/thermal_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/thermal_core.c
> b/drivers/thermal/thermal_core.c index 9bf10aa..fbf301a 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -368,7 +368,7 @@ static void handle_critical_trips(struct
> thermal_zone_device *tz, tz->ops->get_trip_temp(tz, trip, &trip_temp);
>  
>  	/* If we have not crossed the trip_temp, we do not care. */
> -	if (tz->temperature < trip_temp)
> +	if (trip_temp <= 0 || tz->temperature < trip_temp)

To be honest, I regard this as a feature :-), not bug.

In this way I know that on some systems the regulator for thermal unit
is not enabled (which results in read temp of 0xFF).

I'd prefer to keep this as is.

>  		return;
>  
>  	trace_thermal_zone_trip(tz, trip, trip_type);



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group