Re: [PATCH 0/4] Add TMU support for Exynos7

[Lukasz Majewski <l.majewski@samsung.com>]

Hi Abhilash,

> Hi Bartlomiej,
> 
> On Fri, Nov 14, 2014 at 5:49 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > Hi,
> >
> > On Friday, November 14, 2014 04:47:58 PM Abhilash Kesavan wrote:
> >> The Thermal Management Unit (TMU) in Exynos7 provides
> >> software-controlled (thermal throttling) and hardware-controlled
> >> (thermal tripping) management schemes.
> >> There are several changes in terms of the register and bit offsets
> >> in the Exynos7 TMU from that in older SoCs. There are also new
> >> bits, more trigger levels and a special clock for TMU that has
> >> been introduced in Exynos7. This patchset modifies the thermal
> >> driver to handle all these changes.
> >>
> >> This series is based on linux-next(20141114) and tested on an
> >> Exynos7-based espresso board.
> >
> > Please rebase your patchset on top of:
> >
> >   http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg38717.html
> 
> Sure, will rebase on top of your patchset. Is this patchset going to
> be merged into Eduardo's tree soon ?
> 
> >
> > There is also ongoing work to convert Exynos thermal driver to use
> > device tree but Lukasz Majewski (added to Cc:) knows better the
> > current state of the work.
> 
> Lukasz, are you in the process of making changes to the existing
> exynos tmu bindings ?

Yes. I'm working on them.

Please consider following patches [1]:
http://www.spinics.net/lists/linux-samsung-soc/msg37719.html

They are based on top of Bartek's work.
Patch set status:
1. Fixes for thermal_core (with -EPROBE_DEFER) - v2 posted yesterday.
http://www.spinics.net/lists/linux-samsung-soc/msg37719.html

2. of-thermal rework - I'm working on it now (to export common data
from of-thermal.c and provide structure with ops). 

Patches [1] replace configuration available in exynos_tmu_data.c to the
one from device tree. Also it handles setting cpu cooling frequencies
per CPUs via device tree.


I think that it is Eduardo's decision about how Exynos patches should
be serialized.

I can only say that after Bartek's and my [1] patch sets the exynos TMU
driver is much simpler with significant code base reduction.

Personally I think that it may be far more easier to add Exynos7 TMU
support to reworked driver.


> 
> Regards,
> Abhilash
> >
> >> Abhilash Kesavan (4):
> >>   thermal: exynos: add optional sclk support
> >>   thermal: exynos: add a triminfo_mask field in exynos_tmu_register
> >>     structure
> >>   thermal: exynos: modify the prototype for code_to_temp function
> >>   thermal: exynos: Add TMU support for Exynos7 SoC
> >>
> >>  .../devicetree/bindings/thermal/exynos-thermal.txt |    4 +
> >>  drivers/thermal/samsung/exynos_tmu.c               |  106
> >> ++++++++++++++----
> >> drivers/thermal/samsung/exynos_tmu.h               |   13 ++-
> >> drivers/thermal/samsung/exynos_tmu_data.c          |  117
> >> ++++++++++++++++++++
> >> drivers/thermal/samsung/exynos_tmu_data.h          |   27 +++++ 5
> >> files changed, 247 insertions(+), 20 deletions(-)
> >
> > Best regards,
> > --
> > Bartlomiej Zolnierkiewicz
> > Samsung R&D Institute Poland
> > Samsung Electronics
> >



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group