From: Thierry Reding <thierry.reding@gmail.com>
To: Lukasz Majewski <l.majewski@samsung.com>
Cc: Mikko Perttunen <mikko.perttunen@kapsi.fi>,
Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Vincenzo Frascino <vincenzo.frascino@st.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Lukasz Majewski <l.majewski@majess.pl>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver
Date: Mon, 17 Nov 2014 12:57:44 +0100 [thread overview]
Message-ID: <20141117115743.GG25699@ulmo> (raw)
In-Reply-To: <20141114122437.6742ea68@amdc2363>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
On Fri, Nov 14, 2014 at 12:24:37PM +0100, Lukasz Majewski wrote:
> Hi Mikko,
>
> > Tested-by: Mikko Perttunen <mikko.perttunen@kapsi.fi>
>
> Thanks for testing.
>
> >
> > One potential issue I can see is that if the cpufreq driver fails to
> > probe then you'll never get the thermal driver either. For example,
> > Tegra124 currently has no cpufreq driver, so if CONFIG_CPU_THERMAL
> > was enabled, then the soctherm driver would never be able to probe.
>
> Yes, this is a potential issue. However, this option in tegra_defconfig
> is by default disabled when thermal is enabled.
Not everybody uses tegra_defconfig for their kernel builds. In fact I'd
imagine that the majority of kernels use a variant of multi_v7_defconfig
and therefore CPU_THERMAL might get enabled irrespective of any Tegra
support.
I think a better solution would be to add this check only when proper
support for CPU frequency based cooling is added. That is, when a call
to cpufreq_cooling_register() (or a variant thereof) is added.
But while at it, why not make it so that cpufreq_cooling_register()
detects if a cpufreq driver has been registered yet and propagate
-EPROBE_DEFER if necessary?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-17 11:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 8:27 [PATCH 0/3] thermal: fix: Various fixes for thermal subsystem Lukasz Majewski
2014-09-24 8:27 ` [PATCH 1/3] thermal: step_wise: fix: Prevent from binary overflow when trend is dropping Lukasz Majewski
2014-10-02 21:13 ` Eduardo Valentin
2014-10-03 7:26 ` Lukasz Majewski
2014-10-09 3:14 ` Zhang Rui
2014-09-24 8:27 ` [PATCH 2/3] thermal: core: fix: Initialize the max_state variable to 0 Lukasz Majewski
2014-10-02 22:26 ` Eduardo Valentin
2014-10-03 8:26 ` Lukasz Majewski
2014-10-06 18:01 ` Eduardo Valentin
2014-09-24 8:27 ` [PATCH 3/3] thermal: core: fix: Check return code of the ->get_max_state() callback Lukasz Majewski
2014-10-02 22:24 ` Eduardo Valentin
2014-10-03 10:40 ` Lukasz Majewski
2014-10-09 3:15 ` Zhang Rui
2014-10-09 16:47 ` Lukasz Majewski
2014-10-02 14:40 ` [PATCH 0/3] thermal: fix: Various fixes for thermal subsystem Lukasz Majewski
[not found] ` <1411547232-21493-1-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-13 17:02 ` [PATCH 0/8] thermal:cpu cooling:fix: Provide thermal core fixes with deferred probe for several drivers Lukasz Majewski
2014-11-13 17:02 ` [PATCH 1/8] thermal:cpu cooling:armada: Provide deferred probing for armada driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 2/8] thermal:cpu cooling:kirkwood: Provide deferred probing for kirkwood driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 3/8] thermal:cpu cooling:rcar: Provide deferred probing for rcar driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 4/8] thermal:cpu cooling:spear: Provide deferred probing for spear driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver Lukasz Majewski
2014-11-14 10:47 ` Mikko Perttunen
2014-11-14 11:24 ` Lukasz Majewski
2014-11-17 11:57 ` Thierry Reding [this message]
2014-11-17 12:51 ` Lukasz Majewski
2014-11-17 13:18 ` Thierry Reding
[not found] ` <5465DDC5.6090301-/1wQRMveznE@public.gmane.org>
2014-11-17 11:43 ` Thierry Reding
2014-11-17 11:50 ` Lukasz Majewski
2014-11-17 12:01 ` Thierry Reding
2014-11-17 13:02 ` Lukasz Majewski
2014-11-17 12:51 ` Mikko Perttunen
2014-11-17 13:08 ` Thierry Reding
2014-11-17 13:24 ` Mikko Perttunen
[not found] ` <1415898165-27406-6-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-17 11:40 ` Thierry Reding
2014-11-13 17:02 ` [PATCH 6/8] thermal:cpu cooling:ti: Provide deferred probing for ti drivers Lukasz Majewski
2014-11-20 19:00 ` Eduardo Valentin
2014-11-13 17:02 ` [PATCH 7/8] thermal:core:fix: Initialize the max_state variable to 0 Lukasz Majewski
[not found] ` <1415898165-27406-1-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-13 17:02 ` [PATCH 8/8] thermal:core:fix: Check return code of the ->get_max_state() callback Lukasz Majewski
2014-11-20 18:54 ` [PATCH 0/8] thermal:cpu cooling:fix: Provide thermal core fixes with deferred probe for several drivers Eduardo Valentin
2014-11-21 8:33 ` Lukasz Majewski
2014-11-21 2:47 ` Eduardo Valentin
2014-11-21 16:28 ` Lukasz Majewski
2014-11-18 10:16 ` [PATCH v2] thermal:core:fix: Check return code of the ->get_max_state() callback Lukasz Majewski
[not found] ` <1416305790-27746-1-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-21 18:08 ` Eduardo Valentin
2014-11-24 10:38 ` Lukasz Majewski
2014-11-24 11:00 ` Viresh Kumar
2014-11-24 14:24 ` Lukasz Majewski
2014-11-25 10:46 ` Viresh Kumar
2014-11-24 18:02 ` Eduardo Valentin
2014-11-24 20:28 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117115743.GG25699@ulmo \
--to=thierry.reding@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=edubezval@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gnurou@gmail.com \
--cc=iwamatsu@nigauri.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=l.majewski@majess.pl \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mikko.perttunen@kapsi.fi \
--cc=mperttunen@nvidia.com \
--cc=rui.zhang@intel.com \
--cc=swarren@wwwdotorg.org \
--cc=vincenzo.frascino@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).