Re: [PATCH 21/21] thermal: exynos: Make Exynos3250 TMU compatible with Exynos4412

Lukasz Majewski
2014-10-10T08:51:59Z

Hi Chanwoo,

> On 10/10/2014 01:38 AM, Lukasz Majewski wrote:
> > Since both SoCs have the same TMU IP block embedded on them, it is
> > not necessary to maintain separate compatible entry.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > ---
> > drivers/thermal/samsung/exynos_tmu.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c
> > b/drivers/thermal/samsung/exynos_tmu.c index f1e8c9b..7818e2f 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -744,9 +744,6 @@ static irqreturn_t exynos_tmu_irq(int irq, void
> > *id)
> > static const struct of_device_id exynos_tmu_match[] = {
> > {
> > - .compatible = "samsung,exynos3250-tmu",
> > - },
> > - {
>
> If you want to remove compatible string for Exynos3250,
> you have to modify it on exynos3250.dtsi.
>

Thanks for pointing this out. I've overlooked this dtsi file.

> Thanks,
> Chanwoo Choi

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group