Re: [PATCH v2 00/17] thermal: exynos: Thermal code rework to use device tree

Abhilash Kesavan
2014-12-23T15:27:38Z

Hi Lukasz,

On Mon, Dec 22, 2014 at 9:51 PM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> Hi Abhilash,
>
>> Hi Lukasz and Eduardo,
>>
>> [...]
>> >
>> > Although, this shouldn't be a problem.
>> >
>> >> That is why we had the cycle with cpufreq folks, remember?
>> >>
>> >> (I will have a look in your patches)
>> >
>> > It would be great if those patches could find their way to therma
>> > -next. Then also Abhilash could benefit from them.
>>
>> I have a couple of 5420/5800 based chromebooks that I will test this
>> series on. Is it OK for me to start basing my Exynos7 TMU support on
>> this series ? Please let me know if I can help in any other way with
>> this.
>
> I'm fine if you rebase on top of my patches.
>
> However, it is up to Eduardo when he decides to pull them to -next
> branch.
>
> I hope that it will happen soon.

I tested a Peach Pit (5420 based chromebook) with your patches and
they work well (temperatures and software tripping). However, my
earlier comments with regards to duplicate exynos_tmu_initialize() and
the thermal zone showing as disabled in sysfs .

Also, I think the documentation for the dt properties are missing ?

I will post my exynos7 work based on your patches soon. Please take a look.

Regards,
Abhilash
>
>>
>> Regards,
>> Abhilash
>
>
>
> --
> Best regards,
>
> Lukasz Majewski
>
> Samsung R&D Institute Poland (SRPOL) | Linux Platform Group