From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH v12 03/10] qcom: spm: Add Subsystem Power Manager driver Date: Wed, 26 Nov 2014 18:01:22 -0700 Message-ID: <20141127010122.GD5137@linaro.org> References: <1417047195-18978-1-git-send-email-lina.iyer@linaro.org> <1417047195-18978-4-git-send-email-lina.iyer@linaro.org> <7hk32hcvkx.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Received: from mail-pd0-f178.google.com ([209.85.192.178]:53049 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbaK0BBZ (ORCPT ); Wed, 26 Nov 2014 20:01:25 -0500 Received: by mail-pd0-f178.google.com with SMTP id g10so3813027pdj.23 for ; Wed, 26 Nov 2014 17:01:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <7hk32hcvkx.fsf@deeprootsystems.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Kevin Hilman Cc: daniel.lezcano@linaro.org, sboyd@codeaurora.org, galak@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, msivasub@codeaurora.org, devicetree@vger.kernel.org On Wed, Nov 26 2014 at 17:53 -0700, Kevin Hilman wrote: >Lina Iyer writes: > >> SPM is a hardware block that controls the peripheral logic surrounding >> the application cores (cpu/l$). When the core executes WFI instruction, >> the SPM takes over the putting the core in low power state as >> configured. The wake up for the SPM is an interrupt at the GIC, which >> then completes the rest of low power mode sequence and brings the core >> out of low power mode. >> >> The SPM has a set of control registers that configure the SPMs >> individually based on the type of the core and the runtime conditions. >> SPM is a finite state machine block to which a sequence is provided and >> it interprets the bytes and executes them in sequence. Each low power >> mode that the core can enter into is provided to the SPM as a sequence. >> >> Configure the SPM to set the core (cpu or L2) into its low power mode, >> the index of the first command in the sequence is set in the SPM_CTL >> register. When the core executes ARM wfi instruction, it triggers the >> SPM state machine to start executing from that index. The SPM state >> machine waits until the interrupt occurs and starts executing the rest >> of the sequence until it hits the end of the sequence. The end of the >> sequence jumps the core out of its low power mode. >> >> Add support for an idle driver to set up the SPM to place the core in >> Standby or Standalone power collapse mode when the core is idle. >> >> Based on work by: Mahesh Sivasubramanian , >> Ai Li , Praveen Chidambaram >> Original tree available at - >> git://codeaurora.org/quic/la/kernel/msm-3.10.git >> >> Signed-off-by: Lina Iyer > >[...] > >> diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c >> new file mode 100644 >> index 0000000..e5d3ebd >> --- /dev/null >> +++ b/drivers/soc/qcom/spm.c >> @@ -0,0 +1,328 @@ >> +/* Copyright (c) 2011-2014, The Linux Foundation. All rights reserved. > >nit: one more multi-line coding style missed (no need to repost just for >this, feel free to just updated it locally) > >After that, feel free to add: Thanks, I am going to send an updated set later tonight. This will be fixed. > >Reviewed-by: Kevin Hilman