From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v7 08/11] arm/arm64: Unexport restart handlers Date: Thu, 4 Dec 2014 08:11:08 -0800 Message-ID: <20141204161108.GA7385@roeck-us.net> References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <54807505.2000406@roeck-us.net> <3875532.ABOh5kXkPb@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:45832 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932577AbaLDQMY (ORCPT ); Thu, 4 Dec 2014 11:12:24 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1XwZ0x-0032h3-Vq for linux-pm@vger.kernel.org; Thu, 04 Dec 2014 16:12:24 +0000 Content-Disposition: inline In-Reply-To: <3875532.ABOh5kXkPb@wuerfel> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Arnd Bergmann Cc: Geert Uytterhoeven , Russell King , Wim Van Sebroeck , Catalin Marinas , Maxime Ripard , Andrew Morton , "linux-samsung-soc@vger.kernel.org" , Linux Watchdog Mailing List , Linux PM list , Dmitry Eremin-Solenikov , Tomasz Figa , Randy Dunlap , Will Deacon , "linux-kernel@vger.kernel.org" , Steven Rostedt , Jonas Jensen , "linux-doc@vger.kernel.org" , David Woodhouse , Ingo Molnar , linux-arm-kernel@lists On Thu, Dec 04, 2014 at 04:06:22PM +0100, Arnd Bergmann wrote: > On Thursday 04 December 2014 06:51:49 Guenter Roeck wrote: > > On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote: > > > On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck wrote: > > >> On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote: > > >>> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck wrote: > > >>>> Implementing a restart handler in a module don't make sense > > >>>> as there would be no guarantee that the module is loaded when > > >>>> a restart is needed. Unexport arm_pm_restart to ensure that > > >>>> no one gets the idea to do it anyway. > > >>> > > >>> Why not? I was just going to do that, but I got greeted by: > > >> > > >> Because you should register a restart handler instead, like the other > > >> drivers in the same directory now do. > > > > > > That's a different thing. "there would be no guarantee that the module is > > > loaded when a restart is needed" is also valid for restart handlers... > > > > > > > Not really, because you are supposed to unregister the restart handler > > on unload. Sure, you can instead clear arm_pm_reastart and leave the system > > with no means to restart ... > > I agree with Geert that your commit message was confusing, it sounds like > you were referring to drivers that are not yet loaded, while the problem > that you are really address is drivers that have been unloaded later. > Yes, I realize that now. I should probably have added the rationale for the entire series to this commit. I'll try to do better next time. Guenter