Re: [RFC PATCH v6 9/9] of: thermal: Introduce sustainable power for a thermal zone

Javi Merino
2015-01-06T13:29:29Z

On Tue, Jan 06, 2015 at 01:13:03PM +0000, Eduardo Valentin wrote:
> On Tue, Jan 06, 2015 at 09:42:15AM +0000, Javi Merino wrote:
> > On Fri, Jan 02, 2015 at 03:53:00PM +0000, Eduardo Valentin wrote:
> > > On Fri, Dec 05, 2014 at 07:04:20PM +0000, Javi Merino wrote:
> > > > From: Punit Agrawal <punit.agrawal@arm.com>
> > > >
> > > > Introduce an optional property called, sustainable-power, which
> > > > represents the power (in mW) which the thermal zone can safely
> > > > dissipate.
> > > >
> > > > If provided the property is parsed and associated with the thermal
> > > > zone via the thermal zone parameters.
> > > >
> > > > Cc: Zhang Rui <rui.zhang@intel.com>
> > > > Cc: Eduardo Valentin <edubezval@gmail.com>
> > > > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> > > > ---
> > > > Documentation/devicetree/bindings/thermal/thermal.txt | 4 ++++
> > > > drivers/thermal/of-thermal.c | 4 ++++
> > > > 2 files changed, 8 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> > > > index f5db6b72a36f..c6eb9a8d2aed 100644
> > > > --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> > > > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> > > > @@ -167,6 +167,10 @@ Optional property:
> > > > by means of sensor ID. Additional coefficients are
> > > > interpreted as constant offset.
> > > >
> > > > +- sustainable-power: An estimate of the sustainable power (in mW) that the
> > > > + Type: unsigned thermal zone can dissipate.
> > > > + Size: one cell
> > > > +
> > >
> > > Please, include examples of this property, as you mentioned in the
> > > governor documentation.
> >
> > I'd rather put a pointer to the documentation instead of repeating the
> > same thing here. What do you think?
>
> The point is that device tree and Linux are supposed to be independent
> entities. I would prefer if you could extend the explanation of what is
> 'sustainable power' in the above entry. On top of that, pick one of the
> existing examples and extend it to include the 'sustainable-power' property,
> with a comment explaining it, for instance.

Ok, I'll do that.

Cheers,
Javi