Re: [PATCH 1/2] powercap/rapl: add ids for future xeon cpus

[Jacob Pan <jacob.jun.pan@linux.intel.com>]

On Mon, 15 Dec 2014 16:36:48 -0800
Guenter Roeck <linux@roeck-us.net> wrote:

> On Mon, Dec 15, 2014 at 10:14:15AM -0800, Jacob Pan wrote:
> > Enable RAPL driver on Xeon cpu id 0x56.
> > 
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > ---
> >  drivers/powercap/intel_rapl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/powercap/intel_rapl.c
> > b/drivers/powercap/intel_rapl.c index c71443c..ee00ffb 100644
> > --- a/drivers/powercap/intel_rapl.c
> > +++ b/drivers/powercap/intel_rapl.c
> > @@ -1041,6 +1041,7 @@ static const struct x86_cpu_id rapl_ids[] = {
> >  	RAPL_CPU(0x45, rapl_defaults_core),/* Haswell ULT */
> >  	RAPL_CPU(0x4C, rapl_defaults_atom),/* Braswell */
> >  	RAPL_CPU(0x4A, rapl_defaults_atom),/* Tangier */
> > +	RAPL_CPU(0x56, rapl_defaults_atom),/* Future Xeon */
> 
> Is rapl_defaults_atom correct, or should this be rapl_defaults_core ?
> 
you are right should be core, will fix.

thanks
> Guenter
> 
> >  	RAPL_CPU(0x5A, rapl_defaults_atom),/* Annidale */
> >  	{}
> >  };
> > -- 
> > 1.9.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> > 
> > 

[Jacob Pan]