Re: [PATCH] PM / sleep: add configurable delay for pm_test

Pavel Machek
2014-12-17T08:09:47Z

> > 40 lines of code, and new sysfs interface for use by someone who puts
> > the probes on board, anyway... (so should be able to add the single
> > mdelay himself).
>
> I heard your complaint the first time:
>
> https://lkml.org/lkml/2014/9/4/63
>
> And I responded to it already:
>
> https://lkml.org/lkml/2014/9/4/494
>
> You did not respond, but Chirantan spoke up saying he wanted such a
> patch too. He came up with a very similar solution independently:

I know. I believe your patch is so crazy that no more discussion was neccessary.

> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/15bccc2c63c3475ef61d3187c73ccf1d80b18c7e
>
> But since you've decided to make the same comment again, I will detail
> more of the reasons why I think your suggestion ("go add the mdelay
> yourself") is off-base.
>
> 1. This is behind a debug config option (CONFIG_PM_DEBUG). So what's
> the problem with improving its usefulness? Non-debug users can easily
> compile it out if they're worried about 40 lines.

We are talking 40 unneccessary lines of source. Imagine everyone who
needed to change one value added 40 lines of code. Terabyte
kernel. Overengineered. Crazy. Something we'll have to maintain
forever.

Make it module parameter so that the patch is two lines of code. If
that does not work for you, think of something that does.

> 2. The current debug code encodes a particular policy (which kernels
> generally should not). Is it better if I submit a patch that changes
> the current magic delay to 60000 milliseconds? What about 1334
> milliseconds?
>
> 3. To continue your argument: why would I ever try to patch the
> upstream kernel, if I'm perfectly capable of doing this myself?

Good questions. Showing that perhaps you should not patch the
upstream.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html